You're right, I'll incorporate the logic for lambdas into FindDeclRefsVisitor and change the docs/comments/commit message to reflect this. I will try to think of more edge cases to test as well. Though I'll be busy until mid march with uni, so there will be no new revisions until then.

1. addressed comments

Nvmd, Wrapped</*lambda type*/> won't work. I'll look into this some more.

Ping

Add change to release notes

Ping

Ping

Fix windows build by setting the c++ standard for the hoisting tests explicitly to c++17.

Fixup: rm added includes

Ping

Ping

lower c++ version requirement by making the fixes conditional on c++20 instead of the whole check

• address all comments
• minor renames of variables/functions
• add missing & when accessing OptTokens value
• rebase onto current HEAD
• fix llvm::Optional member deprecation warnings
• add support to match when the parameter type explicitly instantiaties itself (i.e. const A<T>& instead of const A& for template <typename T> struct A {...};)

I've got everything done locally, but I'm waiting on the decision on the bitset to update the diff, including some minor additional updates I will list then.

Ping

Gentle Ping

Ping

Question: Should this check be extended to also include C.86: "Flag an operator==() for which the argument types differ; same for other comparison operators: !=, <, <=, >, and >=."? With a warning along the lines of: "comparison operators should be symmetric with respect to the parameters types" or "parameters of comparison operators should be of the same type" (or some other warning). Or should that be a new check? I think it fits.

Address inlining isLanguageVersionSupported

Fixup for the same reason

Fixup addressing comments, missed changing the links for docs

Addressed comments

rm wrong op from isComparisonOperator

rm unused function