This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Add error for subprocess and dummy perf counters
ClosedPublic

Authored by aidengrossman on Aug 11 2023, 1:22 AM.

Details

Summary

When using the subprocess execution mode and dummy perf counters
currently, cryptic errors will be printed out related to not being able
to send the file descriptor through a socket. This patch prints out an
explicit message that this configuration isn't (currently) supported.

Diff Detail

Event Timeline

aidengrossman created this revision.Aug 11 2023, 1:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 1:22 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
aidengrossman requested review of this revision.Aug 11 2023, 1:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 1:22 AM

The plan is to support this configuration at some point (probably soon) as it should be fairly useful in a downstream application I'm working on, but for now we should report a better error message.

Bump on this when reviewers have a chance. Thanks!

courbet accepted this revision.Sep 5 2023, 5:16 AM
This revision is now accepted and ready to land.Sep 5 2023, 5:16 AM