This is an archive of the discontinued LLVM Phabricator instance.

Differential D157251

[X86][regcall] Do not produce @ number suffix if it is regcall4
AbandonedPublic

Authored by yubing on Aug 6 2023, 8:12 PM.

Details

Reviewers
erichkeane
pengfei
mikerice

Diff Detail

Event Timeline

yubing created this revision.Aug 6 2023, 8:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 8:12 PM
yubing requested review of this revision.Aug 6 2023, 8:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 8:12 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yubing added reviewers: erichkeane, pengfei.Aug 6 2023, 8:17 PM
Harbormaster completed remote builds in B250667: Diff 547632.Aug 6 2023, 10:48 PM
yubing updated this revision to Diff 548477.Aug 8 2023, 11:40 PM

add testcase

Herald added a subscriber: mstorsjo. · View Herald TranscriptAug 8 2023, 11:40 PM
yubing updated this revision to Diff 548478.Aug 8 2023, 11:47 PM

small fix

yubing updated this revision to Diff 548479.Aug 8 2023, 11:51 PM

small fix

Harbormaster completed remote builds in B251293: Diff 548479.Aug 9 2023, 2:06 AM
pengfei accepted this revision.Aug 9 2023, 7:16 AM

LGTM.

This revision is now accepted and ready to land.Aug 9 2023, 7:16 AM
yubing added a reviewer: mikerice.Aug 9 2023, 7:56 PM
yubing abandoned this revision.Aug 23 2023, 12:35 AM

Revision Contents

PathSize
clang/
lib/
AST/
4 lines
test/
CodeGen/
43 lines

Diff 548479

clang/lib/AST/Mangle.cpp

//===--- Mangle.cpp - Mangle C++ Names --------------------------*- C++ -*-===// //===--- Mangle.cpp - Mangle C++ Names --------------------------*- C++ -*-===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 198 Lines • ▼ Show 20 Lines#endif
if (!MCXX) if (!MCXX)
Out << D->getIdentifier()->getName(); Out << D->getIdentifier()->getName();
else if (const ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(D)) else if (const ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(D))
mangleObjCMethodNameAsSourceName(OMD, Out); mangleObjCMethodNameAsSourceName(OMD, Out);
else else
mangleCXXName(GD, Out); mangleCXXName(GD, Out);
// do no produce @<number> suffix if it is regcall4
if (getASTContext().getLangOpts().RegCall4)
return;
const FunctionDecl *FD = cast<FunctionDecl>(D); const FunctionDecl *FD = cast<FunctionDecl>(D);
const FunctionType *FT = FD->getType()->castAs<FunctionType>(); const FunctionType *FT = FD->getType()->castAs<FunctionType>();
const FunctionProtoType *Proto = dyn_cast<FunctionProtoType>(FT); const FunctionProtoType *Proto = dyn_cast<FunctionProtoType>(FT);
if (CC == CCM_Vector) if (CC == CCM_Vector)
Out << '@'; Out << '@';
Out << '@'; Out << '@';
if (!Proto) { if (!Proto) {
Out << '0'; Out << '0';
▲ Show 20 Lines • Show All 381 Lines • Show Last 20 Lines

clang/test/CodeGen/mangle-windows-regcall4.c

  • This file was added.
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=i386-pc-win32 -regcall4 | FileCheck %s
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=i386-mingw32 -regcall4 | FileCheck %s
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=i386-pc-windows-msvc-elf -regcall4 | FileCheck %s --check-prefix=ELF32
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=x86_64-pc-win32 -regcall4 | FileCheck %s --check-prefix=X64
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=x86_64-mingw32 -regcall4 | FileCheck %s --check-prefix=X64
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=x86_64-pc-windows-msvc-elf -regcall4 | FileCheck %s --check-prefix=ELF64
// CHECK: target datalayout = "e-m:x-{{.*}}"
// X64: target datalayout = "e-m:w-{{.*}}"
// ELF32: target datalayout = "e-m:e-{{.*}}"
// ELF64: target datalayout = "e-m:e-{{.*}}"
void __regcall v1(void) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v1
// X64: define dso_local x86_regcallcc void @__regcall4__v1
// ELF32: define{{.*}} x86_regcallcc void @__regcall4__v1
// ELF64: define{{.*}} x86_regcallcc void @__regcall4__v1
void __regcall v2(char a) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v2
// X64: define dso_local x86_regcallcc void @__regcall4__v2
// ELF32: define{{.*}} x86_regcallcc void @__regcall4__v2
// ELF64: define{{.*}} x86_regcallcc void @__regcall4__v2
void __regcall v3(short a) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v3
// X64: define dso_local x86_regcallcc void @__regcall4__v3
void __regcall v4(int a) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v4
// X64: define dso_local x86_regcallcc void @__regcall4__v4
void __regcall v5(long long a) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v5
// X64: define dso_local x86_regcallcc void @__regcall4__v5
void __regcall v6(char a, char b) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v6(i8 inreg noundef signext %a, i8 inreg noundef signext %b)
// X64: define dso_local x86_regcallcc void @__regcall4__v6(i8 noundef %a, i8 noundef %b)
void __regcall v7(long long a, char b, char c, short d) {}
// CHECK: define dso_local x86_regcallcc void @__regcall4__v7(i64 noundef %a, i8 inreg noundef signext %b, i8 inreg noundef signext %c, i16 inreg noundef signext %d)
// X64: define dso_local x86_regcallcc void @__regcall4__v7(i64 noundef %a, i8 noundef %b, i8 noundef %c, i16 noundef %d)