This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Don't try to use SYS_rseq if it's not defined.
ClosedPublic

Authored by Romain-Geissler-1A on Aug 5 2023, 3:38 AM.

Details

Summary

When compiling against recent glibc (>= 2.35) but old kernel headers (< 4.18), SYS_rseq is not defined and thus llvm-exegesis fails to build. So also check that SYS_rseq is defined before trying to use it.

Fixes https://github.com/llvm/llvm-project/issues/64456

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2023, 3:38 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
Romain-Geissler-1A requested review of this revision.Aug 5 2023, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2023, 3:38 AM
MaskRay accepted this revision.Aug 6 2023, 6:51 AM
This revision is now accepted and ready to land.Aug 6 2023, 6:51 AM

@MaskRay Thanks for reviewing this.

It's reported above in this UI that it causes some build failure, but I doubt the build failure are related to this. Is it ok to ignore them ? Also, can you please post this patch for me, as I have no right to push in the github repository ?

gchatelet accepted this revision.Aug 7 2023, 12:28 AM
gchatelet added a subscriber: gchatelet.

Thx for the patch @Romain-Geissler-1A . I'll submit the patch on your behalf.

This revision was landed with ongoing or failed builds.Aug 7 2023, 12:33 AM
This revision was automatically updated to reflect the committed changes.

Since this is probably a configuration that people will be running the 17.x release on, I've opened up https://github.com/llvm/llvm-project/issues/64482#issuecomment-1667352876 to backport this change. Thanks for the patch!