This is an archive of the discontinued LLVM Phabricator instance.

Differential D157134

fix build error.
ClosedPublic

Authored by Peiming on Aug 4 2023, 1:26 PM.

Details

Reviewers
aartbik
nicolasvasilache
Commits
rG2b1bdc9f0bc6: fix build error.
Summary

To fix build error introduced in https://reviews.llvm.org/D157025

Diff Detail

Event Timeline

Peiming created this revision.Aug 4 2023, 1:26 PM
Herald added a reviewer: aartbik. · View Herald TranscriptAug 4 2023, 1:26 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, hanchung, jsetoain and 24 others. · View Herald Transcript
Peiming requested review of this revision.Aug 4 2023, 1:26 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptAug 4 2023, 1:26 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming mentioned this in D157025: [mlir][transform][sparse] introduce sparse tensor transform extension..Aug 4 2023, 1:26 PM
aartbik accepted this revision.Aug 4 2023, 1:30 PM
This revision is now accepted and ready to land.Aug 4 2023, 1:30 PM
Peiming added a subscriber: ftynse.Aug 4 2023, 1:33 PM
Peiming added inline comments.
mlir/lib/Dialect/SparseTensor/TransformOps/CMakeLists.txt
13

@ftynse is it possible to move the parseSemiFunctionType outside MLIRLinalgTransformOps to get rid of this dependency?

Peiming edited the summary of this revision. (Show Details)Aug 4 2023, 1:36 PM
This revision was landed with ongoing or failed builds.Aug 4 2023, 1:38 PM
Closed by commit rG2b1bdc9f0bc6: fix build error. (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rG2b1bdc9f0bc6: fix build error..
Harbormaster completed remote builds in B250420: Diff 547325.Aug 4 2023, 2:47 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
SparseTensor/
TransformOps/
1 line

Diff 547325

mlir/lib/Dialect/SparseTensor/TransformOps/CMakeLists.txt

add_mlir_dialect_library(MLIRSparseTensorTransformOps add_mlir_dialect_library(MLIRSparseTensorTransformOps
SparseTensorTransformOps.cpp SparseTensorTransformOps.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SparseTensor/TransformOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SparseTensor/TransformOps
DEPENDS DEPENDS
MLIRSparseTensorTransformOpsIncGen MLIRSparseTensorTransformOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRSparseTensorDialect MLIRSparseTensorDialect
MLIRLinalgTransformOps
PeimingAuthorUnsubmitted
Done
ReplyInline Actions

@ftynse is it possible to move the parseSemiFunctionType outside MLIRLinalgTransformOps to get rid of this dependency?

Peiming: @ftynse is it possible to move the parseSemiFunctionType outside MLIRLinalgTransformOps to get…
MLIRParser MLIRParser
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
MLIRTransformDialect MLIRTransformDialect
MLIRTransformDialectUtils MLIRTransformDialectUtils
) )