This is an archive of the discontinued LLVM Phabricator instance.

ASan: Add additional wcs* interceptors on Windows
AcceptedPublic

Authored by strega-nil on Aug 3 2023, 2:26 PM.

Details

Summary

This adds wcs[n]cat, wcs[n]cmp, wcs[n]cpy, and wcschr functions to the interception code on Windows; wcs[n]cat was already intercepted, but only on POSIX.

Diff Detail

Event Timeline

strega-nil created this revision.Aug 3 2023, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2023, 2:26 PM
Herald added a subscriber: Enna1. · View Herald Transcript
strega-nil requested review of this revision.Aug 3 2023, 2:26 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptAug 3 2023, 2:26 PM

Add interceptors for the debug runtime on x86

minor naming change

Attempting to add more metadata

(ping; I'd like to get this reviewed so that we can merge it at the same time into public LLVM as into MSVC's version)

rnk accepted this revision.Aug 18 2023, 2:47 PM

lgtm

compiler-rt/lib/interception/interception_win.cpp
620

These encodings have spiraled out of control. I'm just trusting they are correct.

This revision is now accepted and ready to land.Aug 18 2023, 2:47 PM
This revision was automatically updated to reflect the committed changes.
This revision is now accepted and ready to land.Aug 21 2023, 3:46 PM