This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Delete probably wrong constant folding of expm1
ClosedPublic

Authored by arsenm on Aug 2 2023, 6:58 AM.

Details

Reviewers
rampitec
foad
Pierre-vh
jmmartinez
Group Reviewers
Restricted Project
Summary

It's not really correct to implement this as exp(x) - 1, it was maybe
OK for the restricted float-as-double case handled here. There's not a
strong reason to special case it with the host function, as the
implementation naturally constant folds anyway. InstSimplify can fully
handle everything in it, so just running the inliner alone with a
constant argument produces the fully constant folded result. This also
had no tests.

Diff Detail

Event Timeline

arsenm created this revision.Aug 2 2023, 6:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 6:58 AM
arsenm requested review of this revision.Aug 2 2023, 6:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 6:58 AM
Herald added a subscriber: wdng. · View Herald Transcript
jmmartinez accepted this revision.Aug 4 2023, 3:25 AM
This revision is now accepted and ready to land.Aug 4 2023, 3:25 AM