Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/index/SymbolCollector.cpp | ||
---|---|---|
851–862 | can you add a comment here saying, We update providers for a symbol with each occurence, as SymbolCollector might run while parsing, rather than at the end of a translation unit. Hence we see more and more redecls over time. | |
919 | we should keep the getStdHeaders logic for objc | |
941 | can you add a // FIXME: Get rid of this once include-cleaner has support for system headers. to this branch | |
944 | again a comment saying For physical files, prefer URIs as spellings might change depending on the translation unit. | |
clang-tools-extra/include-cleaner/lib/FindHeaders.cpp | ||
129 | can you also add comment move(ExecutionPolicy&& policy, ForwardIt1 first, ForwardIt1 last, ForwardIt2 d_first ); and move this change into a separate patch with a test case in clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp? | |
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc | ||
365 ↗ | (On Diff #545562) | can you move this into a separate patch? |
clang-tools-extra/clangd/index/SymbolCollector.cpp | ||
---|---|---|
919 | getStdHeaders returns empty string for Obj-C, are you sure you meant it? |
clang-tools-extra/clangd/index/SymbolCollector.cpp | ||
---|---|---|
919 | it reads a little bit weird, but it still actually works, for objective-c++ to be more specific. as we'll have LangOpts.CPlusPlus set for objc++ |
clang-tools-extra/clangd/index/SymbolCollector.cpp | ||
---|---|---|
921 | Sorry, juggling unconnected stuff makes me inattentive. |
sorry i got confused, this also works for ObjC, not just ObjC++. we set C-like features for ObjectiveC. can you just restore as-is?