This is an archive of the discontinued LLVM Phabricator instance.

Differential D156411

[clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.
ClosedPublic

Authored by mboehme on Jul 27 2023, 3:14 AM.

Details

Reviewers
NoQ
sammccall
Commits
rG771d7d71df41: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

Diff Detail

Event Timeline

mboehme created this revision.Jul 27 2023, 3:14 AM
Herald added a reviewer: NoQ. · View Herald TranscriptJul 27 2023, 3:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: martong, xazax.hun. · View Herald Transcript
mboehme requested review of this revision.Jul 27 2023, 3:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 3:14 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mboehme added a reviewer: sammccall.Jul 27 2023, 3:14 AM
sammccall accepted this revision.Jul 27 2023, 3:53 AM
This revision is now accepted and ready to land.Jul 27 2023, 3:53 AM
Harbormaster completed remote builds in B248492: Diff 544680.Jul 27 2023, 4:20 AM
mboehme added a comment.Jul 27 2023, 5:59 AM

Pre-merge failure looks unrelated

This revision was landed with ongoing or failed builds.Jul 27 2023, 6:02 AM
Closed by commit rG771d7d71df41: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks. (authored by mboehme). · Explain Why
This revision was automatically updated to reflect the committed changes.
mboehme added a commit: rG771d7d71df41: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks..

Revision Contents

PathSize
clang/
lib/
Analysis/
FlowSensitive/
5 lines

Diff 544733

clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp

Show First 20 Lines • Show All 456 Lines • ▼ Show 20 Lines GraphS << R"(digraph {
tooltip=" " tooltip=" "
node[class=bb, shape=square, fontname="sans-serif", tooltip=" "] node[class=bb, shape=square, fontname="sans-serif", tooltip=" "]
edge[tooltip = " "] edge[tooltip = " "]
)"; )";
for (unsigned I = 0; I < CFG.getNumBlockIDs(); ++I) for (unsigned I = 0; I < CFG.getNumBlockIDs(); ++I)
GraphS << " " << blockID(I) << " [id=" << blockID(I) << "]\n"; GraphS << " " << blockID(I) << " [id=" << blockID(I) << "]\n";
for (const auto *Block : CFG) { for (const auto *Block : CFG) {
for (const auto &Succ : Block->succs()) { for (const auto &Succ : Block->succs()) {
if (Succ.getReachableBlock())
GraphS << " " << blockID(Block->getBlockID()) << " -> " GraphS << " " << blockID(Block->getBlockID()) << " -> "
<< blockID(Succ.getReachableBlock()->getBlockID()) << "\n"; << blockID(Succ.getReachableBlock()->getBlockID()) << "\n";
} }
} }
GraphS << "}\n"; GraphS << "}\n";
return Graph; return Graph;
} }
}; };
// Nothing interesting here, just subprocess/temp-file plumbing. // Nothing interesting here, just subprocess/temp-file plumbing.
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines