In D150653#4345771, @ymandel wrote:

I'm a little confused by one of the points in the description:

setValueStrict(): The RFC proposes that this should always create the same StorageLocation for a given Value, but, in fact, the transfer functions that exist today don't guarantee this; almost all transfer functions unconditionally create a new StorageLocation when associating an expression with a Value.

Since values are immutable, we (intentionally) share them between different storage locations. So, it makes sense that a single value could be associated with multiple storage locations. Now, there's a bug in that values aren't really immutable since you can update the fields, so we have a false sharing bug in the framework, but maybe that only applies to glvalues?

Tue, May 16, 6:54 AM · Restricted Project, Restricted Project

mboehme updated the diff for D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors..

Tweaked preconditions (in comments and code)

Tue, May 16, 6:45 AM · Restricted Project, Restricted Project

mboehme added inline comments to D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Tue, May 16, 6:37 AM · Restricted Project, Restricted Project

mboehme added inline comments to D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Tue, May 16, 6:26 AM · Restricted Project, Restricted Project

mboehme updated the diff for D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Simplified else { if {} } to else if {}.

Tue, May 16, 6:26 AM · Restricted Project, Restricted Project

mboehme added inline comments to D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Tue, May 16, 6:09 AM · Restricted Project, Restricted Project

mboehme added inline comments to D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Tue, May 16, 5:24 AM · Restricted Project, Restricted Project

mboehme added inline comments to D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp..

Tue, May 16, 5:21 AM · Restricted Project, Restricted Project

mboehme updated the diff for D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp..

Added a comment

Tue, May 16, 5:13 AM · Restricted Project, Restricted Project

mboehme updated the summary of D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp..

Tue, May 16, 3:18 AM · Restricted Project, Restricted Project

mboehme updated the summary of D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp..

Tue, May 16, 3:17 AM · Restricted Project, Restricted Project

mboehme requested review of D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp..

Tue, May 16, 3:17 AM · Restricted Project, Restricted Project

mboehme requested review of D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp..

Tue, May 16, 3:17 AM · Restricted Project, Restricted Project

mboehme updated the summary of D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Tue, May 16, 3:16 AM · Restricted Project, Restricted Project

mboehme requested review of D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp..

Tue, May 16, 3:15 AM · Restricted Project, Restricted Project

mboehme updated the summary of D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors..

Tue, May 16, 2:56 AM · Restricted Project, Restricted Project

mboehme requested review of D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors..

Tue, May 16, 2:55 AM · Restricted Project, Restricted Project

Mon, May 15

mboehme added a comment to rG2239fd50bd80: Fix build failure caused by https://reviews.llvm.org/D150352.

Sorry for the breakage, and thank you for fixing.

Mon, May 15, 11:57 AM · Restricted Project, Restricted Project

mboehme updated subscribers of D150352: [clang][dataflow] Don't analyze templated declarations..

In D150352#4342480, @uabelho wrote:

Hello,

../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: error: 'build' is deprecated: Use the version that takes a const Decl & instead [-Werror,-Wdeprecated-declarations]
      ControlFlowContext::build(&FuncDecl, *FuncDecl.getBody(), ASTCtx);
                          ^
../../clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:41:3: note: 'build' has been explicitly marked deprecated here
  LLVM_DEPRECATED("Use the version that takes a const Decl & instead", "")
  ^
../include/llvm/Support/Compiler.h:143:50: note: expanded from macro 'LLVM_DEPRECATED'
#define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
                                                 ^
1 error generated.

Mon, May 15, 11:56 AM · Restricted Project, Restricted Project

mboehme committed rG1a42f795587b: [clang][dataflow] Don't analyze templated declarations. (authored by mboehme).

[clang][dataflow] Don't analyze templated declarations.

Mon, May 15, 4:05 AM · Restricted Project, Restricted Project

mboehme closed D150352: [clang][dataflow] Don't analyze templated declarations..

Mon, May 15, 4:05 AM · Restricted Project, Restricted Project

mboehme updated the diff for D150352: [clang][dataflow] Don't analyze templated declarations..

Spell -fno-delayed-template-parsing correctly (it was missing a hyphen).

Mon, May 15, 2:24 AM · Restricted Project, Restricted Project

mboehme added inline comments to D150352: [clang][dataflow] Don't analyze templated declarations..

Mon, May 15, 12:50 AM · Restricted Project, Restricted Project

mboehme updated the diff for D150352: [clang][dataflow] Don't analyze templated declarations..