Page MenuHomePhabricator

mboehme (Martin Böhme)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 2:26 AM (192 w, 2 d)

Recent Activity

Sep 17 2019

mboehme added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

Martin should know who should look at this... maybe Krasimir?

Sep 17 2019, 1:42 AM · Restricted Project, Restricted Project

Sep 9 2019

mboehme added inline comments to D67292: [clang-tidy] Fix bug in bugprone-use-after-move check.
Sep 9 2019, 12:56 AM · Restricted Project, Restricted Project

Jan 15 2019

mboehme committed rCTE351303: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
[clang-tidy] Treat references to smart pointers correctly in use-after-move.
Jan 15 2019, 11:57 PM
mboehme committed rL351303: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
[clang-tidy] Treat references to smart pointers correctly in use-after-move.
Jan 15 2019, 11:57 PM
mboehme closed D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
Jan 15 2019, 11:57 PM · Restricted Project
mboehme added a comment to D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..

LGTM, is there a bug report for this issue? If yes please close that too :)

Jan 15 2019, 11:36 PM · Restricted Project

Jan 11 2019

mboehme added a reviewer for D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.: alexfh.
Jan 11 2019, 2:13 AM · Restricted Project
mboehme updated the diff for D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..

Removing experimental code that shouldn't have been added.

Jan 11 2019, 2:13 AM · Restricted Project
mboehme created D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
Jan 11 2019, 2:09 AM · Restricted Project

Oct 4 2018

mboehme committed rCTE343768: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
[clang-tidy] Sequence statements with multiple parents correctly (PR39149)
Oct 4 2018, 4:41 AM
mboehme committed rL343768: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
[clang-tidy] Sequence statements with multiple parents correctly (PR39149)
Oct 4 2018, 4:41 AM
mboehme closed D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
Oct 4 2018, 4:41 AM · Restricted Project
mboehme added a comment to D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).

Thanks for clarification :)

Oct 4 2018, 3:32 AM · Restricted Project
mboehme added inline comments to D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
Oct 4 2018, 1:48 AM · Restricted Project
mboehme updated the diff for D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
  • Responses to reviewer comments.
Oct 4 2018, 1:44 AM · Restricted Project

Oct 2 2018

mboehme created D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
Oct 2 2018, 7:39 AM · Restricted Project

Sep 26 2018

mboehme accepted D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:20 AM

Sep 25 2018

mboehme accepted D52451: Add macro LLVM_ATTRIBUTE_REINITIALIZES.
Sep 25 2018, 12:26 AM

Aug 13 2018

mboehme committed rCTE339571: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after….
[clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after…
Aug 13 2018, 7:25 AM
mboehme committed rL339571: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after….
[clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after…
Aug 13 2018, 7:25 AM
mboehme closed D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Aug 13 2018, 7:25 AM · Restricted Project
mboehme committed rL339569: Summary:Add clang::reinitializes attribute.
Summary:Add clang::reinitializes attribute
Aug 13 2018, 7:11 AM
mboehme committed rC339569: Summary:Add clang::reinitializes attribute.
Summary:Add clang::reinitializes attribute
Aug 13 2018, 7:11 AM
mboehme closed D49911: Summary:Add clang::reinitializes attribute.
Aug 13 2018, 7:11 AM
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Thank you for the review!

Aug 13 2018, 6:54 AM · Restricted Project
mboehme updated the diff for D49911: Summary:Add clang::reinitializes attribute.

Rebase to head.

Aug 13 2018, 6:50 AM
mboehme updated the diff for D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Rebase to head.

Aug 13 2018, 6:50 AM · Restricted Project

Aug 3 2018

mboehme committed rL338932: [clang-tidy] Sequence init statements, declarations, and conditions correctly….
[clang-tidy] Sequence init statements, declarations, and conditions correctly…
Aug 3 2018, 3:20 PM
mboehme committed rCTE338932: [clang-tidy] Sequence init statements, declarations, and conditions correctly….
[clang-tidy] Sequence init statements, declarations, and conditions correctly…
Aug 3 2018, 3:20 PM
mboehme closed D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Aug 3 2018, 3:20 PM · Restricted Project
mboehme updated the diff for D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Apply clang-format.

Aug 3 2018, 2:26 PM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Sorry, that code got formatted strangely. Here's the same code block in more legible form:

Aug 3 2018, 11:56 AM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Are you going to propose adding this attribute to libc++, or is this expected to only work with UDTs?

I don't have any experience contributing to libc++, but I think this would make sense.

The check currently hard-codes various member functions of classes in the "std" namespace that do reinitializations; I'm not sure though if those can be removed after the attribute has been added to libc++. We'd would also presumably have to add the attribute to libstdc++ -- does it accept Clang-only attributes? And what is the story for people using clang-tidy with MSVC projects? (I have to admit I'm very hazy on how that works...)

I ask the question because it's novel to add an attribute to Clang that's used only by clang-tidy, and I'm wondering who is expected to use that attribute to help with this check. Is it expected to be an attribute users use with their own custom datatypes and it's not needed for standards-based APIs (because we handle those some other way), or something else? As it stands, I sort of feel like this is a very heavy approach to solve an edge case -- is there a lot of evidence for re-using a moved-from object after reinitializing it?

Aug 3 2018, 11:54 AM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Are you going to propose adding this attribute to libc++, or is this expected to only work with UDTs?

Aug 3 2018, 7:44 AM · Restricted Project
mboehme added a comment to D49911: Summary:Add clang::reinitializes attribute.

Thanks for the review!

Aug 3 2018, 7:32 AM
mboehme updated the diff for D49911: Summary:Add clang::reinitializes attribute.

Various changes in response to review comments.

Aug 3 2018, 7:29 AM
mboehme added a comment to D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Any further comments? This is marked ready to land, but I've made some non-trivial changes since then, so I didn't just want to land this.

Aug 3 2018, 7:12 AM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Any comments?

Aug 3 2018, 6:40 AM · Restricted Project

Jul 31 2018

mboehme retitled D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while from [clang-tidy] Sequence declaration in while statement before the condition to [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Jul 31 2018, 10:04 AM · Restricted Project
mboehme added inline comments to D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Jul 31 2018, 10:03 AM · Restricted Project
mboehme updated the diff for D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Add support for switch statement.

Jul 31 2018, 10:00 AM · Restricted Project

Jul 30 2018

mboehme added a comment to D49911: Summary:Add clang::reinitializes attribute.

Should this attribute have some semantic checking that ensures the non-static data members are accessed in the function that claims it reinitializes the object?

Jul 30 2018, 1:10 PM
mboehme updated the diff for D49911: Summary:Add clang::reinitializes attribute.

Various changes in response to reviewer comments.

Jul 30 2018, 12:53 PM

Jul 27 2018

mboehme created D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Jul 27 2018, 7:35 AM · Restricted Project
mboehme retitled D49911: Summary:Add clang::reinitializes attribute from Summary: Add clang::reinitializes attribute to Summary:Add clang::reinitializes attribute.
Jul 27 2018, 5:46 AM
mboehme updated the summary of D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Jul 27 2018, 5:31 AM · Restricted Project
mboehme created D49911: Summary:Add clang::reinitializes attribute.
Jul 27 2018, 5:30 AM
mboehme retitled D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move from Reviewers: to [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Jul 27 2018, 5:25 AM · Restricted Project
mboehme updated the diff for D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

[clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Jul 27 2018, 5:19 AM · Restricted Project
mboehme created D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Jul 27 2018, 5:16 AM · Restricted Project

Feb 15 2018

mboehme committed rC325236: Add -no-canonical-prefixes to allow different build modes..
Add -no-canonical-prefixes to allow different build modes.
Feb 15 2018, 5:54 AM
mboehme committed rL325236: Add -no-canonical-prefixes to allow different build modes..
Add -no-canonical-prefixes to allow different build modes.
Feb 15 2018, 5:54 AM

Dec 20 2017

mboehme committed rCTE321156: [clangd] Add "../" to Logger.h included from parent directory..
[clangd] Add "../" to Logger.h included from parent directory.
Dec 20 2017, 1:18 AM
mboehme committed rL321156: [clangd] Add "../" to Logger.h included from parent directory..
[clangd] Add "../" to Logger.h included from parent directory.
Dec 20 2017, 1:18 AM

Dec 18 2017

mboehme committed rC320971: [X86] Use {{.*}} instead of hardcoded %1 in knot test..
[X86] Use {{.*}} instead of hardcoded %1 in knot test.
Dec 18 2017, 3:30 AM
mboehme committed rL320971: [X86] Use {{.*}} instead of hardcoded %1 in knot test..
[X86] Use {{.*}} instead of hardcoded %1 in knot test.
Dec 18 2017, 3:30 AM

Oct 24 2017

mboehme committed rL316497: Revert "[CodeGen][ExpandMemcmp][NFC] Allow memcmp to expand to vector loads (1)".
Revert "[CodeGen][ExpandMemcmp][NFC] Allow memcmp to expand to vector loads (1)"
Oct 24 2017, 1:40 PM

Aug 30 2017

mboehme committed rL312109: Add test case that was broken by r311970..
Add test case that was broken by r311970.
Aug 30 2017, 3:46 AM
mboehme committed rL312108: Revert "Improve constant expression evaluation of arrays of unknown bound.".
Revert "Improve constant expression evaluation of arrays of unknown bound."
Aug 30 2017, 3:46 AM

Mar 30 2017

mboehme added inline comments to D31370: [clang-tidy] Prototype to check for exception specification.
Mar 30 2017, 3:04 AM
mboehme added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

(Apologies for the late reply)

Mar 30 2017, 3:00 AM

Mar 22 2017

mboehme added a comment to D31245: Correct class-template deprecation behavior-REDUX.

Spelling: Filename template-multiple-attr-propegation.cpp should be "...propagation.cpp"

Mar 22 2017, 10:02 AM
mboehme committed rL298504: Revert "Correct class-template deprecation behavior".
Revert "Correct class-template deprecation behavior"
Mar 22 2017, 6:47 AM
mboehme committed rL298503: Revert "iFix Test deprecation behavior in C89 mode as a result of r298410".
Revert "iFix Test deprecation behavior in C89 mode as a result of r298410"
Mar 22 2017, 6:45 AM
mboehme added a comment to rL298410: Correct class-template deprecation behavior.

This doesn't correctly propagate attributes on declarations that have more than one attribute of the same kind (repro below).

Mar 22 2017, 6:32 AM

Mar 20 2017

mboehme added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

@aaron.ballman i asked on the mailing list and we had a little discussion for a general noexcept check. Most were the opinion that flow analysis should be enough.

Mar 20 2017, 9:00 AM

Mar 8 2017

mboehme committed rL297272: [clang-tidy] misc-use-after-move: Fix failing assertion.
[clang-tidy] misc-use-after-move: Fix failing assertion
Mar 8 2017, 4:46 AM
mboehme closed D30650: [clang-tidy] misc-use-after-move: Fix failing assertion by committing rL297272: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 8 2017, 4:46 AM
mboehme added a comment to D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.

I think we should refactor this check as part of Static Analyzer, since it's path-sensitive.

Are you saying it should be path sensitive? Because currently it's not, right?

Mar 8 2017, 4:45 AM

Mar 7 2017

mboehme committed rL297129: [analyzer] Fix crash when building CFG with variable of incomplete type.
[analyzer] Fix crash when building CFG with variable of incomplete type
Mar 7 2017, 12:54 AM
mboehme closed D30636: [analyzer] Fix crash when building CFG with variable of incomplete type by committing rL297129: [analyzer] Fix crash when building CFG with variable of incomplete type.
Mar 7 2017, 12:54 AM

Mar 6 2017

mboehme added a comment to D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.

LG. So you won the flappy column game? ;)

Mar 6 2017, 7:32 AM
mboehme added inline comments to D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 6 2017, 6:51 AM
mboehme created D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 6 2017, 6:47 AM
mboehme committed rL297006: Revert "[clang-tidy] misc-use-after-move: Fix failing assertion".
Revert "[clang-tidy] misc-use-after-move: Fix failing assertion"
Mar 6 2017, 1:58 AM
mboehme added a comment to rL297004: [clang-tidy] misc-use-after-move: Fix failing assertion.

This is causing buildbots to fail. Will roll back.

Mar 6 2017, 1:52 AM
mboehme created D30636: [analyzer] Fix crash when building CFG with variable of incomplete type.
Mar 6 2017, 1:44 AM
mboehme committed rL297004: [clang-tidy] misc-use-after-move: Fix failing assertion.
[clang-tidy] misc-use-after-move: Fix failing assertion
Mar 6 2017, 1:07 AM
mboehme closed D30569: [clang-tidy] misc-use-after-move: Fix failing assertion by committing rL297004: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 6 2017, 1:07 AM

Mar 3 2017

mboehme added inline comments to D30569: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 3 2017, 5:57 AM
mboehme added inline comments to D30569: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 3 2017, 5:07 AM
mboehme added inline comments to D30569: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 3 2017, 5:06 AM
mboehme created D30569: [clang-tidy] misc-use-after-move: Fix failing assertion.
Mar 3 2017, 5:03 AM

Feb 14 2017

mboehme added a comment to D27751: [LLVM] Use after move bug fixes.

What's the status of this change in general? There seem to be a couple of comments that are still open?

Feb 14 2017, 7:34 AM

Jan 25 2017

mboehme added a comment to D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug..

Most of us subscribe to llvm-commits (et al), and filter by the keywords we care ("arm", "aarch64", etc.), so we see all the patches that go though.

If the fix is small and obvious, a direct commit is fine, as long as you explain what you can about what the bug does, how it's being tested, where it came from, etc.

Jan 25 2017, 7:52 AM
mboehme added a comment to D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug..

Then say that on the description. What introduced the bug, how did you find out, etc. It helps a lot to know where things came from, not just what they are.

Jan 25 2017, 7:33 AM
mboehme added a comment to D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug..

Also, it would have helped if you had mentioned the commit that introduced the bug, so that it tracks down when people want to revert (the original commit) for some reason.

Jan 25 2017, 6:54 AM
mboehme added a comment to D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug..

Do you mean why I added rovka@ as a reviewer? My intent was that she would see this, as she's the original author of rL293035. But I take it that's not a usual thing to do? Apologies, still learning how to do things around here.

Jan 25 2017, 6:53 AM
mboehme added a comment to D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug..

This fixes a bug that was introduced in rL293035. That revision looks as if it provides tests along with the code.

Jan 25 2017, 6:45 AM
mboehme committed rL293059: [ARM] GlobalISel: Fix stack-use-after-scope bug..
[ARM] GlobalISel: Fix stack-use-after-scope bug.
Jan 25 2017, 6:39 AM
mboehme closed D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug. by committing rL293059: [ARM] GlobalISel: Fix stack-use-after-scope bug..
Jan 25 2017, 6:39 AM
mboehme created D29124: [ARM] GlobalISel: Fix stack-use-after-scope bug..
Jan 25 2017, 6:37 AM
mboehme committed rL293051: [Driver] Prevent no-arc-exception-silence.m test from writing output..
[Driver] Prevent no-arc-exception-silence.m test from writing output.
Jan 25 2017, 5:07 AM
mboehme closed D29123: [Driver] Prevent no-arc-exception-silence.m test from writing output. by committing rL293051: [Driver] Prevent no-arc-exception-silence.m test from writing output..
Jan 25 2017, 5:07 AM
mboehme created D29123: [Driver] Prevent no-arc-exception-silence.m test from writing output..
Jan 25 2017, 5:05 AM

Jan 24 2017

mboehme closed D29076: [X86][SSE] Add explicit braces to avoid -Wdangling-else warning. by committing rL292924: [X86][SSE] Add explicit braces to avoid -Wdangling-else warning..
Jan 24 2017, 4:42 AM
mboehme committed rL292924: [X86][SSE] Add explicit braces to avoid -Wdangling-else warning..
[X86][SSE] Add explicit braces to avoid -Wdangling-else warning.
Jan 24 2017, 4:42 AM
mboehme created D29076: [X86][SSE] Add explicit braces to avoid -Wdangling-else warning..
Jan 24 2017, 4:37 AM

Jan 23 2017

mboehme committed rL292791: Revert "IRGen: Start using the WriteThinLTOBitcode pass.".
Revert "IRGen: Start using the WriteThinLTOBitcode pass."
Jan 23 2017, 6:44 AM
mboehme closed D29025: Revert "IRGen: Start using the WriteThinLTOBitcode pass." by committing rL292791: Revert "IRGen: Start using the WriteThinLTOBitcode pass.".
Jan 23 2017, 6:44 AM