Page MenuHomePhabricator

mboehme (Martin Böhme)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 2:26 AM (223 w, 5 d)

Recent Activity

Jul 14 2020

mboehme committed rGc912f7c9cc44: [clang] Always allow including builtin headers in [no_undeclared_headers]… (authored by mboehme).
[clang] Always allow including builtin headers in [no_undeclared_headers]…
Jul 14 2020, 4:54 PM
mboehme committed rGc1f3bf0e3fb8: [clang] Add an API to retrieve implicit constructor arguments. (authored by mboehme).
[clang] Add an API to retrieve implicit constructor arguments.
Jul 14 2020, 4:51 PM

Jun 15 2020

mboehme added a comment to D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible().

Test case(s)?

Jun 15 2020, 10:00 PM · Restricted Project

Jun 12 2020

mboehme created D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible().
Jun 12 2020, 5:22 AM · Restricted Project
mboehme committed rG2e92b397ae4b: [clang] Rename Decl::isHidden() to isUnconditionallyVisible(). (authored by mboehme).
[clang] Rename Decl::isHidden() to isUnconditionallyVisible().
Jun 12 2020, 1:03 AM
mboehme closed D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible().
Jun 12 2020, 1:03 AM · Restricted Project
mboehme added a comment to D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible().

I think renaming the flag in the AST dump output would be a good idea, though it'll be a lot of churn in the tests. I would prefer that we continue to dump a marker only if the declaration is not unconditionally visible rather than reversing the sense of the flag in the dump output.

Jun 12 2020, 12:30 AM · Restricted Project

Jun 8 2020

mboehme created D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible().
Jun 8 2020, 7:05 AM · Restricted Project

Jun 4 2020

mboehme closed D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules..
Jun 4 2020, 1:34 AM · Restricted Project
mboehme added a comment to D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules..

Committed as https://github.com/llvm/llvm-project/commit/8d74de9de6d6cca552d7de7d0bfd36b6dd7d58dc.

Jun 4 2020, 1:34 AM · Restricted Project

Jun 3 2020

mboehme committed rG8d74de9de6d6: [clang] Always allow including builtin headers in [no_undeclared_headers]… (authored by mboehme).
[clang] Always allow including builtin headers in [no_undeclared_headers]…
Jun 3 2020, 11:57 PM
mboehme added a comment to D80448: [lldb/Test] Add a trace method to replace (commented out) print statements..

Thank you!

Jun 3 2020, 10:29 PM · Restricted Project
mboehme committed rGa3220dffcb1d: [clangd] Add std::move() to a return statement to please some compilers. (authored by mboehme).
[clangd] Add std::move() to a return statement to please some compilers.
Jun 3 2020, 7:08 AM
mboehme closed D81079: [clangd] Add std::move() to a return statement to please some compilers..
Jun 3 2020, 7:07 AM · Restricted Project, Restricted Project
mboehme abandoned D81080: [clang-tidy] Compile fix: Change CPlusPlus2a to CPlusPlus20..
Jun 3 2020, 5:27 AM · Restricted Project, Restricted Project
mboehme added a comment to D81080: [clang-tidy] Compile fix: Change CPlusPlus2a to CPlusPlus20..

Already fixed in

Jun 3 2020, 5:27 AM · Restricted Project, Restricted Project
mboehme created D81080: [clang-tidy] Compile fix: Change CPlusPlus2a to CPlusPlus20..
Jun 3 2020, 4:20 AM · Restricted Project, Restricted Project
mboehme created D81079: [clangd] Add std::move() to a return statement to please some compilers..
Jun 3 2020, 4:20 AM · Restricted Project, Restricted Project

Jun 2 2020

mboehme added inline comments to D80448: [lldb/Test] Add a trace method to replace (commented out) print statements..
Jun 2 2020, 11:58 PM · Restricted Project

May 29 2020

mboehme added a reviewer for D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.: rsmith.
May 29 2020, 6:29 AM · Restricted Project
mboehme updated the diff for D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules..

When testing with the real libc++ and glibc, I realized that I was still getting a cyclic dependency between the two modules because the builtin stddef.h that glibc was including was still being ascribed to libc++.

May 29 2020, 6:29 AM · Restricted Project
mboehme removed a reviewer for D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.: rsmith.
May 29 2020, 5:56 AM · Restricted Project
mboehme added a comment to D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules..

Temporarily retracting from review as I've realized there's another case I need to take care of.

May 29 2020, 5:56 AM · Restricted Project
mboehme added a reviewer for D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.: rsmith.
May 29 2020, 2:08 AM · Restricted Project
mboehme created D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules..
May 29 2020, 2:08 AM · Restricted Project

May 18 2020

mboehme added a comment to D79942: [clang] Add an API to retrieve implicit constructor arguments..

Can someone commit for me? I've applied to have my SVN commit access transferred to github, but haven't gotten a response yet.

May 18 2020, 10:12 PM · Restricted Project

May 14 2020

mboehme updated the summary of D79942: [clang] Add an API to retrieve implicit constructor arguments..
May 14 2020, 9:56 PM · Restricted Project
mboehme added a reviewer for D79942: [clang] Add an API to retrieve implicit constructor arguments.: rjmccall.
May 14 2020, 1:36 PM · Restricted Project
mboehme created D79942: [clang] Add an API to retrieve implicit constructor arguments..
May 14 2020, 6:57 AM · Restricted Project

May 7 2020

mboehme added a comment to D79486: [clang] Make arrangeCXX{Constructor,Method}Call() publicly available.

Abandoning this change as I've realized I'm going to need additional features, specifically those related to extra args passed for virtual base classes.

May 7 2020, 5:03 AM · Restricted Project
mboehme abandoned D79486: [clang] Make arrangeCXX{Constructor,Method}Call() publicly available.
May 7 2020, 5:03 AM · Restricted Project

May 6 2020

mboehme added a reviewer for D79486: [clang] Make arrangeCXX{Constructor,Method}Call() publicly available: rjmccall.
May 6 2020, 6:24 AM · Restricted Project
mboehme created D79486: [clang] Make arrangeCXX{Constructor,Method}Call() publicly available.
May 6 2020, 5:52 AM · Restricted Project

Feb 17 2020

mboehme added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

I've added some individual comments above, but I'd question whether it's really necessary to make this change? Even if no move actually happens, the code is still wrong (it shouldn't be using std::move in the first place), and it's likely the author actually intended for a move to happen, so we should warn that that would cause a use-after-move.

Feb 17 2020, 7:11 AM · Restricted Project, Restricted Project

Sep 17 2019

mboehme added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

Martin should know who should look at this... maybe Krasimir?

Sep 17 2019, 1:42 AM · Restricted Project, Restricted Project

Sep 9 2019

mboehme added inline comments to D67292: [clang-tidy] Fix bug in bugprone-use-after-move check.
Sep 9 2019, 12:56 AM · Restricted Project, Restricted Project

Jan 15 2019

mboehme committed rCTE351303: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
[clang-tidy] Treat references to smart pointers correctly in use-after-move.
Jan 15 2019, 11:57 PM
mboehme committed rL351303: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
[clang-tidy] Treat references to smart pointers correctly in use-after-move.
Jan 15 2019, 11:57 PM
mboehme closed D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
Jan 15 2019, 11:57 PM · Restricted Project
mboehme added a comment to D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..

LGTM, is there a bug report for this issue? If yes please close that too :)

Jan 15 2019, 11:36 PM · Restricted Project

Jan 11 2019

mboehme added a reviewer for D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.: alexfh.
Jan 11 2019, 2:13 AM · Restricted Project
mboehme updated the diff for D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..

Removing experimental code that shouldn't have been added.

Jan 11 2019, 2:13 AM · Restricted Project
mboehme created D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move..
Jan 11 2019, 2:09 AM · Restricted Project

Oct 4 2018

mboehme committed rCTE343768: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
[clang-tidy] Sequence statements with multiple parents correctly (PR39149)
Oct 4 2018, 4:41 AM
mboehme committed rL343768: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
[clang-tidy] Sequence statements with multiple parents correctly (PR39149)
Oct 4 2018, 4:41 AM
mboehme closed D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
Oct 4 2018, 4:41 AM · Restricted Project
mboehme added a comment to D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).

Thanks for clarification :)

Oct 4 2018, 3:32 AM · Restricted Project
mboehme added inline comments to D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
Oct 4 2018, 1:48 AM · Restricted Project
mboehme updated the diff for D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
  • Responses to reviewer comments.
Oct 4 2018, 1:44 AM · Restricted Project

Oct 2 2018

mboehme created D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).
Oct 2 2018, 7:39 AM · Restricted Project

Sep 26 2018

mboehme accepted D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:20 AM

Sep 25 2018

mboehme accepted D52451: Add macro LLVM_ATTRIBUTE_REINITIALIZES.
Sep 25 2018, 12:26 AM

Aug 13 2018

mboehme committed rCTE339571: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after….
[clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after…
Aug 13 2018, 7:25 AM
mboehme committed rL339571: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after….
[clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after…
Aug 13 2018, 7:25 AM
mboehme closed D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Aug 13 2018, 7:25 AM · Restricted Project
mboehme committed rL339569: Summary:Add clang::reinitializes attribute.
Summary:Add clang::reinitializes attribute
Aug 13 2018, 7:11 AM
mboehme committed rC339569: Summary:Add clang::reinitializes attribute.
Summary:Add clang::reinitializes attribute
Aug 13 2018, 7:11 AM
mboehme closed D49911: Summary:Add clang::reinitializes attribute.
Aug 13 2018, 7:11 AM
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Thank you for the review!

Aug 13 2018, 6:54 AM · Restricted Project
mboehme updated the diff for D49911: Summary:Add clang::reinitializes attribute.

Rebase to head.

Aug 13 2018, 6:50 AM
mboehme updated the diff for D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Rebase to head.

Aug 13 2018, 6:50 AM · Restricted Project

Aug 3 2018

mboehme committed rL338932: [clang-tidy] Sequence init statements, declarations, and conditions correctly….
[clang-tidy] Sequence init statements, declarations, and conditions correctly…
Aug 3 2018, 3:20 PM
mboehme committed rCTE338932: [clang-tidy] Sequence init statements, declarations, and conditions correctly….
[clang-tidy] Sequence init statements, declarations, and conditions correctly…
Aug 3 2018, 3:20 PM
mboehme closed D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Aug 3 2018, 3:20 PM · Restricted Project
mboehme updated the diff for D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Apply clang-format.

Aug 3 2018, 2:26 PM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Sorry, that code got formatted strangely. Here's the same code block in more legible form:

Aug 3 2018, 11:56 AM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Are you going to propose adding this attribute to libc++, or is this expected to only work with UDTs?

I don't have any experience contributing to libc++, but I think this would make sense.

The check currently hard-codes various member functions of classes in the "std" namespace that do reinitializations; I'm not sure though if those can be removed after the attribute has been added to libc++. We'd would also presumably have to add the attribute to libstdc++ -- does it accept Clang-only attributes? And what is the story for people using clang-tidy with MSVC projects? (I have to admit I'm very hazy on how that works...)

I ask the question because it's novel to add an attribute to Clang that's used only by clang-tidy, and I'm wondering who is expected to use that attribute to help with this check. Is it expected to be an attribute users use with their own custom datatypes and it's not needed for standards-based APIs (because we handle those some other way), or something else? As it stands, I sort of feel like this is a very heavy approach to solve an edge case -- is there a lot of evidence for re-using a moved-from object after reinitializing it?

Aug 3 2018, 11:54 AM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Are you going to propose adding this attribute to libc++, or is this expected to only work with UDTs?

Aug 3 2018, 7:44 AM · Restricted Project
mboehme added a comment to D49911: Summary:Add clang::reinitializes attribute.

Thanks for the review!

Aug 3 2018, 7:32 AM
mboehme updated the diff for D49911: Summary:Add clang::reinitializes attribute.

Various changes in response to review comments.

Aug 3 2018, 7:29 AM
mboehme added a comment to D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Any further comments? This is marked ready to land, but I've made some non-trivial changes since then, so I didn't just want to land this.

Aug 3 2018, 7:12 AM · Restricted Project
mboehme added a comment to D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Any comments?

Aug 3 2018, 6:40 AM · Restricted Project

Jul 31 2018

mboehme retitled D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while from [clang-tidy] Sequence declaration in while statement before the condition to [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Jul 31 2018, 10:04 AM · Restricted Project
mboehme added inline comments to D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Jul 31 2018, 10:03 AM · Restricted Project
mboehme updated the diff for D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.

Add support for switch statement.

Jul 31 2018, 10:00 AM · Restricted Project

Jul 30 2018

mboehme added a comment to D49911: Summary:Add clang::reinitializes attribute.

Should this attribute have some semantic checking that ensures the non-static data members are accessed in the function that claims it reinitializes the object?

Jul 30 2018, 1:10 PM
mboehme updated the diff for D49911: Summary:Add clang::reinitializes attribute.

Various changes in response to reviewer comments.

Jul 30 2018, 12:53 PM

Jul 27 2018

mboehme created D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while.
Jul 27 2018, 7:35 AM · Restricted Project
mboehme retitled D49911: Summary:Add clang::reinitializes attribute from Summary: Add clang::reinitializes attribute to Summary:Add clang::reinitializes attribute.
Jul 27 2018, 5:46 AM
mboehme updated the summary of D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Jul 27 2018, 5:31 AM · Restricted Project
mboehme created D49911: Summary:Add clang::reinitializes attribute.
Jul 27 2018, 5:30 AM
mboehme retitled D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move from Reviewers: to [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Jul 27 2018, 5:25 AM · Restricted Project
mboehme updated the diff for D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

[clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.

Jul 27 2018, 5:19 AM · Restricted Project
mboehme created D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move.
Jul 27 2018, 5:16 AM · Restricted Project

Feb 15 2018

mboehme committed rC325236: Add -no-canonical-prefixes to allow different build modes..
Add -no-canonical-prefixes to allow different build modes.
Feb 15 2018, 5:54 AM
mboehme committed rL325236: Add -no-canonical-prefixes to allow different build modes..
Add -no-canonical-prefixes to allow different build modes.
Feb 15 2018, 5:54 AM

Dec 20 2017

mboehme committed rCTE321156: [clangd] Add "../" to Logger.h included from parent directory..
[clangd] Add "../" to Logger.h included from parent directory.
Dec 20 2017, 1:18 AM
mboehme committed rL321156: [clangd] Add "../" to Logger.h included from parent directory..
[clangd] Add "../" to Logger.h included from parent directory.
Dec 20 2017, 1:18 AM

Dec 18 2017

mboehme committed rC320971: [X86] Use {{.*}} instead of hardcoded %1 in knot test..
[X86] Use {{.*}} instead of hardcoded %1 in knot test.
Dec 18 2017, 3:30 AM
mboehme committed rL320971: [X86] Use {{.*}} instead of hardcoded %1 in knot test..
[X86] Use {{.*}} instead of hardcoded %1 in knot test.
Dec 18 2017, 3:30 AM

Oct 24 2017

mboehme committed rL316497: Revert "[CodeGen][ExpandMemcmp][NFC] Allow memcmp to expand to vector loads (1)".
Revert "[CodeGen][ExpandMemcmp][NFC] Allow memcmp to expand to vector loads (1)"
Oct 24 2017, 1:40 PM

Aug 30 2017

mboehme committed rL312109: Add test case that was broken by r311970..
Add test case that was broken by r311970.
Aug 30 2017, 3:46 AM
mboehme committed rL312108: Revert "Improve constant expression evaluation of arrays of unknown bound.".
Revert "Improve constant expression evaluation of arrays of unknown bound."
Aug 30 2017, 3:46 AM

Mar 30 2017

mboehme added inline comments to D31370: [clang-tidy] Prototype to check for exception specification.
Mar 30 2017, 3:04 AM
mboehme added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

(Apologies for the late reply)

Mar 30 2017, 3:00 AM

Mar 22 2017

mboehme added a comment to D31245: Correct class-template deprecation behavior-REDUX.

Spelling: Filename template-multiple-attr-propegation.cpp should be "...propagation.cpp"

Mar 22 2017, 10:02 AM
mboehme committed rL298504: Revert "Correct class-template deprecation behavior".
Revert "Correct class-template deprecation behavior"
Mar 22 2017, 6:47 AM
mboehme committed rL298503: Revert "iFix Test deprecation behavior in C89 mode as a result of r298410".
Revert "iFix Test deprecation behavior in C89 mode as a result of r298410"
Mar 22 2017, 6:45 AM
mboehme added a comment to rL298410: Correct class-template deprecation behavior.

This doesn't correctly propagate attributes on declarations that have more than one attribute of the same kind (repro below).

Mar 22 2017, 6:32 AM

Mar 20 2017

mboehme added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

@aaron.ballman i asked on the mailing list and we had a little discussion for a general noexcept check. Most were the opinion that flow analysis should be enough.

Mar 20 2017, 9:00 AM