This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Update amdgpu_cs_chain_preserve docs. NFC
ClosedPublic

Authored by rovka on Jul 27 2023, 3:11 AM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Commits
rG71eb8c07dd9b: [AMDGPU] Update amdgpu_cs_chain_preserve docs. NFC
Summary

We no longer allow calls to functions with the amdgpu_gfx calling
convention from functions with the amdgpu_cs_chain_preserve calling
convention. See D153517.

Also mention that we can't have a chain call from
amdgpu_cs_chain_preserve using more VGPRs than it has received.

Diff Detail

Event Timeline

rovka created this revision.Jul 27 2023, 3:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 3:11 AM
rovka requested review of this revision.Jul 27 2023, 3:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 3:11 AM
rovka added a reviewer: Restricted Project.Jul 27 2023, 3:17 AM
rovka updated this revision to Diff 549303.Aug 11 2023, 2:22 AM

Rebase.

arsenm added a subscriber: arsenm.Aug 17 2023, 3:10 PM
arsenm added inline comments.
llvm/docs/AMDGPUUsage.rst
1199

This sentence doesn't read right. "than the caller VGPR function parameters"

rovka updated this revision to Diff 551965.Aug 21 2023, 3:50 AM

Fixed typo.

Does this make sense now? Usually these functions will just forward the arguments they have received, maybe with some minor processing, so the callee shouldn't receive more VGPR arguments than the caller had.

arsenm accepted this revision.Aug 23 2023, 5:22 PM
This revision is now accepted and ready to land.Aug 23 2023, 5:22 PM
This revision was automatically updated to reflect the committed changes.