This is an archive of the discontinued LLVM Phabricator instance.

[Orc][PowerPC] Enable ELFNixPlatform support for ppc64le
ClosedPublic

Authored by lkail on Jul 27 2023, 12:47 AM.

Details

Summary

Since jitlink for ppc64le is ready for general use, test cases in compiler-rt for ELFNixPlatform support can be enabled.

Diff Detail

Event Timeline

lkail created this revision.Jul 27 2023, 12:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 12:47 AM
lkail requested review of this revision.Jul 27 2023, 12:47 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 27 2023, 12:47 AM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
qiucf added a subscriber: qiucf.Jul 27 2023, 12:49 AM
qiucf added inline comments.
llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp
252

ppc64 was also changed in above file, but only ppc64le here?

lkail added inline comments.
llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp
252

Since llvm-jitlink for ppc64 hasn't been well tested yet, I'd rather not enable runtime support for it right now. Will add comment here.

lkail updated this revision to Diff 544639.Jul 27 2023, 12:59 AM
lkail retitled this revision from [Orc] Enable ELFNixPlatform support for ppc64le to [Orc][PowerPC] Enable ELFNixPlatform support for ppc64le.Jul 27 2023, 1:09 AM
lhames accepted this revision.Aug 1 2023, 2:31 PM

LGTM. Thanks @lkail!

Is there a blocker to testing / enabling ppc64 support too, or just haven't gotten around to it yet? I have access to a ppc64 machine and can run tests if that'll help, though I'll only have time to report failures (not debug them).

This revision is now accepted and ready to land.Aug 1 2023, 2:31 PM
lkail added a comment.Aug 1 2023, 6:50 PM

Is there a blocker to testing / enabling ppc64 support too, or just haven't gotten around to it yet?

I haven't added lit tests for ppc64 yet. I'll try to enable ppc64 support after adding those tests. I notice that there is ppc64 buildbot, I'll also check if the bot run runtime tests.

lkail added a comment.Aug 1 2023, 6:57 PM

I'll also check if the bot run runtime tests.

Yes, it does it.

ninja check-all check-runtimes
 in dir /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage2 (timeout 1200 secs)
 watching logfiles {}
 argv: [b'ninja', b'check-all', b'check-runtimes']
This revision was landed with ongoing or failed builds.Aug 1 2023, 7:21 PM
This revision was automatically updated to reflect the committed changes.