Since jitlink for ppc64le is ready for general use, test cases in compiler-rt for ELFNixPlatform support can be enabled.
Details
- Reviewers
lhames StephenFan shchenz - Group Reviewers
Restricted Project - Commits
- rG5cb2a78ac2fe: [Orc][PowerPC] Enable ELFNixPlatform support for ppc64le
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp | ||
---|---|---|
252 | ppc64 was also changed in above file, but only ppc64le here? |
llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp | ||
---|---|---|
252 | Since llvm-jitlink for ppc64 hasn't been well tested yet, I'd rather not enable runtime support for it right now. Will add comment here. |
LGTM. Thanks @lkail!
Is there a blocker to testing / enabling ppc64 support too, or just haven't gotten around to it yet? I have access to a ppc64 machine and can run tests if that'll help, though I'll only have time to report failures (not debug them).
Is there a blocker to testing / enabling ppc64 support too, or just haven't gotten around to it yet?
I haven't added lit tests for ppc64 yet. I'll try to enable ppc64 support after adding those tests. I notice that there is ppc64 buildbot, I'll also check if the bot run runtime tests.
I'll also check if the bot run runtime tests.
Yes, it does it.
ninja check-all check-runtimes in dir /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage2 (timeout 1200 secs) watching logfiles {} argv: [b'ninja', b'check-all', b'check-runtimes']
ppc64 was also changed in above file, but only ppc64le here?