This is an archive of the discontinued LLVM Phabricator instance.

[NFC][clang] Fix static analyzer concerns
ClosedPublic

Authored by Fznamznon on Jul 25 2023, 3:05 AM.

Details

Summary

TypeLocBuilder frees resources in the destructor but doesn't have
user-written copy c'tor or assignment operator, so copying it using
default ones can cause double free.

Diff Detail

Event Timeline

Fznamznon created this revision.Jul 25 2023, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2023, 3:05 AM
Fznamznon requested review of this revision.Jul 25 2023, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2023, 3:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Jul 25 2023, 6:19 AM
Fznamznon updated this revision to Diff 544262.Jul 26 2023, 1:58 AM

Rebase to maybe pass precommit

This revision was automatically updated to reflect the committed changes.