Enable CUDA Fortran support to bbc with -fcuda

[wangzpgi]

Summary

Enable CUDA Fortran support to bbc with -fcuda

[clementval]

LGTM

[wangzpgi]

Using "git show HEAD -U999999 > mypatch.patch" to show more context of the file.

[razvanlupusoru]

flang/tools/bbc/bbc.cpp

422

I don't think you need the change to define _CUDA. The preprocessor entry for this should be enabled solely by enabling the language feature. (parsing.cpp does it).

Since there is no language versioning, I don't think you need to do it the same as _OPENACC. This is required for _OPENACC because the tool sets the desired language level. And this macro must be defined as part of OpenACC spec.

[awarzynski]

Please add a test.

[wangzpgi]

Remove definition of _CUDA 1.

[wangzpgi]

In D155887#4521666, @awarzynski wrote:

Please add a test.

Currently CUDA Fortran is not supported in FIR, there is no correct FIR to check at this moment. So I will add a test later once the support is there.

[wangzpgi]

In D155887#4555598, @wangzpgi wrote:

In D155887#4521666, @awarzynski wrote:

Please add a test.

Currently CUDA Fortran is not supported in FIR, there is no correct FIR to check at this moment. So I will add a test later once the support is there.

I think I am going to add a test in Driver for testing the switch bbc -fcuda. Please stay tuned. Thanks

[wangzpgi]

Add a test for testing the -fcuda option for bbc.

[wangzpgi]

Modified the test so that it's not tied to the value of _CUDA, which is not the intention of this test.
This test is to test that -fcuda option works for bbc.

[clementval]

Still LGTM

[razvanlupusoru]

Looks good to me. Thank you!

[awarzynski]

Thanks for adding a test, LGTM!

In D155887#4555598, @wangzpgi wrote:

In D155887#4521666, @awarzynski wrote:

Please add a test.

Currently CUDA Fortran is not supported in FIR, there is no correct FIR to check at this moment. So I will add a test later once the support is there.

Perhaps this flag should be added when FIR is updated to support CUDA?

[PeteSteinfeld]

All builds and tests correctly and looks good.

Congratulations on your first patch!

flang/test/Driver/bbc-cuda-macro.cuf

+! Test -fcuda option for bbc
+! RUN: bbc -fcuda -o - %s | FileCheck %s
+
+! CHECK-NOT: Unknown command line argument
+
+program main
+#if _CUDA
+  integer :: var = _CUDA
+#endif
+  integer, device :: dvar
+end program

flang/tools/bbc/bbc.cpp

static llvm::cl::opt<bool> enablePolymorphic(
     "polymorphic-type",
     llvm::cl::desc("enable polymorphic type lowering (experimental)"),
     llvm::cl::init(false));
 
 static llvm::cl::opt<bool> useHLFIR("hlfir",
                                     llvm::cl::desc("Lower to high level FIR"),
                                     llvm::cl::init(false));
 
+static llvm::cl::opt<bool> enableCUDA("fcuda",
+                                      llvm::cl::desc("enable CUDA Fortran"),
+                                      llvm::cl::init(false));
+
 #define FLANG_EXCLUDE_CODEGEN
 #include "flang/Tools/CLOptions.inc"
 
 //===----------------------------------------------------------------------===//
 
 using ProgramName = std::string;
 
 // Print the module with the "module { ... }" wrapper, preventing
int main(int argc, char **argv) {
   }
 
   // enable parsing of OpenACC
   if (enableOpenACC) {
     options.features.Enable(Fortran::common::LanguageFeature::OpenACC);
     options.predefinitions.emplace_back("_OPENACC", "202211");
   }
 
+  // enable parsing of CUDA Fortran
+  if (enableCUDA) {
+    options.features.Enable(Fortran::common::LanguageFeature::CUDA);
+  }
+
   Fortran::common::IntrinsicTypeDefaultKinds defaultKinds;
   Fortran::parser::AllSources allSources;
   Fortran::parser::AllCookedSources allCookedSources(allSources);
   Fortran::semantics::SemanticsContext semanticsContext{
       defaultKinds, options.features, allCookedSources};
   semanticsContext.set_moduleDirectory(moduleDir)
       .set_moduleFileSuffix(moduleSuffix)
       .set_searchDirectories(includeDirs)