Depends on D152706
Solves SWDEV-408279
Details
- Reviewers
arsenm - Group Reviewers
Restricted Project - Commits
- rG3cd4afce5b18: [AMDGPU] Allow vector access types in PromoteAllocaToVector
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp | ||
---|---|---|
427 | Please use poison instead of undef as a placeholder whenever possible (like here). |
llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp | ||
---|---|---|
415 | extra parens around getTypeStoreSize | |
467 | Extra parens | |
473 | Is there a benefit to using it here? I'd assume we end up breaking it down anyway during legalization | |
553 | These actually return TypeSize, you can do | |
556 | return isBitOrNoop... | |
llvm/test/CodeGen/AMDGPU/promote-alloca-subvecs.ll | ||
47 | Try some 1 x vectors, those usually break something. Also vectors of pointers, and FP types |
llvm/test/CodeGen/AMDGPU/promote-alloca-subvecs.ll | ||
---|---|---|
47 | And reload ptr as int and int as ptr |
Comments
llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp | ||
---|---|---|
473 | Probably not, it's indeed broken into insert/extracts anyway. I've simplified it. |
extra parens around getTypeStoreSize