This is an archive of the discontinued LLVM Phabricator instance.

[openacc] Update data clause attribute definition
ClosedPublic

Authored by razvanlupusoru on Jul 18 2023, 8:29 AM.

Details

Summary

Instead of using the I64EnumAttr for the DataClause, now use
EnumAttr instead. This makes tests more readable since now
one can use the format #acc<data_clause acc_copyin> instead of
just the number.

Diff Detail

Event Timeline

razvanlupusoru created this revision.Jul 18 2023, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 8:29 AM
razvanlupusoru requested review of this revision.Jul 18 2023, 8:29 AM
vzakhari accepted this revision.Jul 18 2023, 9:34 AM

Looks great! Thank you!

This revision is now accepted and ready to land.Jul 18 2023, 9:34 AM

Did you check the flang tests as well (make check-flang)? I'm surprised that there is no change needed on these tests.

Did you check the flang tests as well (make check-flang)? I'm surprised that there is no change needed on these tests.

Yes. As you already noticed, the changes are here: https://reviews.llvm.org/D155603

Rebase. Also update examples in OpenACCOps.td to use updated dataClause format.

This revision was landed with ongoing or failed builds.Jul 18 2023, 11:39 AM
This revision was automatically updated to reflect the committed changes.