This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Update data clause attribute in tests
ClosedPublic

Authored by razvanlupusoru on Jul 18 2023, 8:20 AM.

Details

Summary

Update Fortran OpenACC tests to use the updated data clause
attribute format for better readability.

Depends on D155605

Diff Detail

Event Timeline

razvanlupusoru created this revision.Jul 18 2023, 8:20 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 18 2023, 8:20 AM
Herald added a subscriber: sunshaoce. · View Herald Transcript
razvanlupusoru requested review of this revision.Jul 18 2023, 8:20 AM

I am currently trying to figure out how to upload the parent patch for this change via arc diff.

Rebase against proper parent.

razvanlupusoru edited the summary of this revision. (Show Details)

Try again to set proper dependency.

razvanlupusoru edited the summary of this revision. (Show Details)

Fix spelling mistake on dependency link. The proper parent is D155605.

You can make these changes as part of D155603 since they are related. Otherwise the pre-commit ci will fail on D155603.

You can make these changes as part of D155603 since they are related. Otherwise the pre-commit ci will fail on D155603.

I can land them both at the same time. It felt better to separate MLIR changes from flang changes. Is that OK? Or do you prefer that they are part of same patch?

You can make these changes as part of D155603 since they are related. Otherwise the pre-commit ci will fail on D155603.

I can land them both at the same time. It felt better to separate MLIR changes from flang changes. Is that OK? Or do you prefer that they are part of same patch?

You can keep it like that this time but it is better to have single commit that can be compiled and tested as a single block without failure. In your case, it is fine to have them together since the change in mlir trigger the change in flang.

This revision is now accepted and ready to land.Jul 18 2023, 11:14 AM
This revision was landed with ongoing or failed builds.Jul 18 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.