This is a follow up to D149722 and aims to address https://github.com/llvm/llvm-project/issues/63885.
Local-exec accesses were not previously accounted for in XCOFFObjectWriter. Specifically, the R_TLS_LE
relocation was not previously handled, which lead to the incorrect value being written for the relocation target.
Within this patch, the value being written is set to the symbol's virtual address and extra relocation tests are added.
Details
Details
- Reviewers
hubert.reinterpretcast power-llvm-team - Group Reviewers
Restricted Project - Commits
- rG8e0e442c1d10: [AIX][TLS] Account for local-exec accesses in XCOFFObjectWriter
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Update aix-tls-le-xcoff-reloc.ll to show the bytes of the encoded value that I originally missed, and also add the correct symbol name that I missed earlier.
Comment Actions
Code change looks good.
For each test:
- Noted the symbol table index for the referenced symbols of each R_TLS_LE relocation.
- Checked that the values encoded "at" the target addresses match the address values of the referenced symbols.
LGTM; thanks!
Copy/paste error?