This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Reorder setMaxAtomicSizeInBitsSupported(). NFC
ClosedPublic

Authored by brad on Jul 15 2023, 11:59 AM.

Details

Summary

Reorder setMaxAtomicSizeInBitsSupported() in numerical and more logical order.

Diff Detail

Event Timeline

brad created this revision.Jul 15 2023, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2023, 11:59 AM
brad requested review of this revision.Jul 15 2023, 11:59 AM

shouldInlineQuadwordAtomics contains a Subtarget.isPPC64() check, so this is NFC for both PPC32 and PPC64.
I wonder whether PPC32 may make shouldInlineQuadwordAtomics true in the future.

brad added a comment.Jul 22 2023, 3:06 PM

shouldInlineQuadwordAtomics contains a Subtarget.isPPC64() check, so this is NFC for both PPC32 and PPC64.

Yes, I would expect shouldInlineQuadwordAtomics to check for the appropriate environment.

I wonder whether PPC32 may make shouldInlineQuadwordAtomics true in the future.

If that were the case I would expect shouldInlineQuadwordAtomics to check what is appropriate.

MaskRay accepted this revision.Jul 22 2023, 3:41 PM
This revision is now accepted and ready to land.Jul 22 2023, 3:41 PM
This revision was landed with ongoing or failed builds.Jul 22 2023, 5:03 PM
This revision was automatically updated to reflect the committed changes.