This is an archive of the discontinued LLVM Phabricator instance.

[ubsan] Disable sigaction.cpp on ubsan-tsan
ClosedPublic

Authored by Caslyn on Jul 14 2023, 10:57 AM.

Details

Summary

Following https://reviews.llvm.org/D155272, restrict to FAIL to ubsan-tsan tests so non-ubsan-tsan tests may still pass, shown by https://lab.llvm.org/buildbot/#/builders/179/builds/6669.

Diff Detail

Event Timeline

Caslyn created this revision.Jul 14 2023, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 10:57 AM
Herald added subscribers: Enna1, pengfei. · View Herald Transcript
Caslyn requested review of this revision.Jul 14 2023, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 10:57 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Caslyn added inline comments.Jul 14 2023, 11:01 AM
compiler-rt/test/ubsan/TestCases/Misc/Linux/sigaction.cpp
8

Build failure examples here:

clang-linux-x64:

  • UBSan-ThreadSanitizer-x86_64 :: TestCases/Misc/Linux/sigaction.cpp

clang-linux-arm64 (Not sure why these are continuing to fail after D155272):

  • UBSan-AddressSanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp
  • UBSan-MemorySanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp
  • UBSan-Standalone-aarch64 :: TestCases/Misc/Linux/sigaction.cpp
Caslyn updated this revision to Diff 540551.Jul 14 2023, 1:27 PM

Amend XFAIL directive

Caslyn updated this revision to Diff 540562.Jul 14 2023, 2:29 PM

Amend XFAIL to include ubsan-tsan

paulkirth added inline comments.
compiler-rt/test/ubsan/TestCases/Misc/Linux/sigaction.cpp
8

do you intend to only disable for aarch64 w/ ubsan + tsan?

Caslyn retitled this revision from [ubsan] Disable sigaction.cpp on archs for debugging to [ubsan] Disable sigaction.cpp on ubsan-tsan .Jul 14 2023, 3:29 PM
Caslyn edited the summary of this revision. (Show Details)
Caslyn added inline comments.Jul 14 2023, 3:32 PM
compiler-rt/test/ubsan/TestCases/Misc/Linux/sigaction.cpp
8

Added ubsan-tsan to disqualifier condition to permit passing cases in https://lab.llvm.org/buildbot/#/builders/179/builds/6669:

  • UBSan-AddressSanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp
  • UBSan-MemorySanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp
  • UBSan-Standalone-aarch64 :: TestCases/Misc/Linux/sigaction.cpp
8

Yes, so that aarch64 buliders may at least pass. It remains unclear how to handle the Linux-64 case for now, since it's not fully apparent that it impacts upstream builders.

https://llvm.org/docs/TestingGuide.html#constraining-test-execution is helpful for figuring out the constraints, as I think the above change enables the test on more targets, instead of on all aarch64 or ubsan-tsan.

you probably want XFAIL: aarch64{{.*}, ubsan-tsan

ah, my mistake. feel free to ignore my following comment

dvyukov accepted this revision.Jul 14 2023, 11:38 PM
This revision is now accepted and ready to land.Jul 14 2023, 11:38 PM
This revision was automatically updated to reflect the committed changes.
hctim added a subscriber: hctim.Jul 17 2023, 1:01 AM

Hey @Caslyn, looks like this unfortunately didn't fix the buildbot breakage caused by https://reviews.llvm.org/D155272, I still see UBSan-ThreadSanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp broken at head (https://lab.llvm.org/buildbot/#/builders/238/builds/4398).

Unexpectedly Passed Tests (1):
UBSan-ThreadSanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp

Do we just disable it instead of XFAIL?

Unexpectedly Passed Tests (1):
UBSan-ThreadSanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp

Do we just disable it instead of XFAIL?

I think so. We can look into reincorporating this test into that configuration once it's been determined why it fails on some builders and passes on others.