Abandoning this attempt - and agree that it's too heavy handed. @mysterymath has taken the lead on debugging.

@dvyukov - I think this could resolve the remaining error we're seeing on Fuchsia linux-x86_64 builds like this one: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8775481122257091553/overview

Amend XFAIL to include ubsan-tsan

Amend XFAIL directive

Thanks @dvyukov - I hope you don't mind I went ahead and committed this on your behalf.

This was reverted due to its dependency on https://reviews.llvm.org/D154943 - please see https://github.com/llvm/llvm-project/issues/63831.

rebased

correct reference in test

Hi Piotr - I'm sorry for the delay in getting back to you. Thank you again for your review comments. I did my best trying to get the right combination of matchers that limit the candidates and allow the exceptions that we want. I wasn't successful in figuring out a way to exempt static references to non-trivial destructor classes that don't have the lifetime extension (see comment).

Changes per review.

Thanks for the review @PiotrZSL, I’m new to this space and appreciate the comments. I have a few questions around some of them and would greatly appreciate any guidance you can give.

Fixes from review.

Provide full error message in comment

Hey - it looks like this is causing build failures on this Fuchsia build bot after this change was landed: https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-host_test_only-mac/b8782262413740663777/overview. I've filed https://github.com/llvm/llvm-project/issues/62505 with a reproducer attached.

Modify comment

LGTM - the failed build doesn't look related to this change.

Amend comment

Removed unnecessary ASSERT_DEATH existance check

Add back AndroidSvelteConfig to Fuchsia combined tests.

Apologies, my local git checkout diverged from the phabricator revision and this patch was merged under https://reviews.llvm.org/rGced95a5765f5743761e72685ecc944dde990305a. Unfortunately the "Fuchsia" typo in the title was not fixed under that revision, but otherwise the merged content is equal. Moving forward with closing this.

Fix Typo

Fix typo

fix size_t param

Thanks for the quick response @gchatelet!

Updates to memmem.cpp/memmem_test.cpp per review feedback

In D147822#4255905, @michaelrj wrote:

Code looks good to me, I've added @gchatelet for his opinion on memmem being in memory_utils.