This is an archive of the discontinued LLVM Phabricator instance.

Differential D155048

[mlir][nvvm] fix potential bug (NFC)
ClosedPublic

Authored by guraypp on Jul 12 2023, 1:02 AM.

Details

Reviewers
ftynse
dcaballe
nicolasvasilache
Commits
rGb6bf775f58ab: [mlir][nvvm] fix potential bug (NFC)

Diff Detail

Event Timeline

guraypp created this revision.Jul 12 2023, 1:02 AM
Herald added a reviewer: ftynse. · View Herald TranscriptJul 12 2023, 1:02 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: gysit, Dinistro, bviyer and 26 others. · View Herald Transcript
guraypp requested review of this revision.Jul 12 2023, 1:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 1:02 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache, jholewinski. · View Herald Transcript
nicolasvasilache accepted this revision.Jul 12 2023, 1:03 AM
This revision is now accepted and ready to land.Jul 12 2023, 1:03 AM
This revision was landed with ongoing or failed builds.Jul 12 2023, 1:09 AM
Closed by commit rGb6bf775f58ab: [mlir][nvvm] fix potential bug (NFC) (authored by guraypp). · Explain Why
This revision was automatically updated to reflect the committed changes.
guraypp added a commit: rGb6bf775f58ab: [mlir][nvvm] fix potential bug (NFC).
Harbormaster completed remote builds in B244692: Diff 539420.Jul 12 2023, 2:50 AM

Revision Contents

PathSize
mlir/
lib/
Conversion/
NVVMToLLVM/
3 lines

Diff 539420

mlir/lib/Conversion/NVVMToLLVM/NVVMToLLVM.cpp

Show First 20 Lines • Show All 106 Lines • ▼ Show 20 Linespublic:
LLVM::InlineAsmOp build() { LLVM::InlineAsmOp build() {
auto asmDialectAttr = auto asmDialectAttr =
LLVM::AsmDialectAttr::get(op->getContext(), LLVM::AsmDialect::AD_ATT); LLVM::AsmDialectAttr::get(op->getContext(), LLVM::AsmDialect::AD_ATT);
Type resultType = hasResult ? op->getResult(0).getType() Type resultType = hasResult ? op->getResult(0).getType()
: LLVM::LLVMVoidType::get(op->getContext()); : LLVM::LLVMVoidType::get(op->getContext());
// Remove the last comma from the constraints string. // Remove the last comma from the constraints string.
if (asmConstraints[asmConstraints.size() - 1] == ',') if (!asmConstraints.empty() &&
asmConstraints[asmConstraints.size() - 1] == ',')
asmConstraints.pop_back(); asmConstraints.pop_back();
return rewriter.create<LLVM::InlineAsmOp>( return rewriter.create<LLVM::InlineAsmOp>(
op->getLoc(), resultType, op->getLoc(), resultType,
/*operands=*/asmVals, /*operands=*/asmVals,
/*asm_string=*/asmStr, /*asm_string=*/asmStr,
/*constraints=*/asmConstraints.data(), /*constraints=*/asmConstraints.data(),
/*has_side_effects=*/sideEffects, /*has_side_effects=*/sideEffects,
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines