This is an archive of the discontinued LLVM Phabricator instance.

Differential D154996

[ConstantHoisting] use BasicBlock::getFirstInsertionPt NFC
ClosedPublic

Authored by nickdesaulniers on Jul 11 2023, 11:47 AM.

Details

Reviewers
ributzka
MaskRay
void
Commits
rG1936bb81aafd: [ConstantHoisting] use BasicBlock::getFirstInsertionPt NFC
Summary

Rather than open coding the same implementation.

Diff Detail

Event Timeline

nickdesaulniers created this revision.Jul 11 2023, 11:47 AM
Herald added a reviewer: ributzka. · View Herald TranscriptJul 11 2023, 11:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
nickdesaulniers requested review of this revision.Jul 11 2023, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 11:47 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
nickdesaulniers added reviewers: MaskRay, void.Jul 11 2023, 11:48 AM
void accepted this revision.Jul 11 2023, 11:53 AM

Nice catch!

This revision is now accepted and ready to land.Jul 11 2023, 11:53 AM
MaskRay accepted this revision.Jul 11 2023, 1:05 PM

Consider adding a NFC:)

nickdesaulniers added a child revision: D155020: [ConstantHoisting] simplify NumUses accounting NFC.Jul 11 2023, 3:00 PM
Harbormaster completed remote builds in B244558: Diff 539220.Jul 11 2023, 4:44 PM
nickdesaulniers retitled this revision from [ConstantHoisting] use BasicBlock::getFirstInsertionPt to [ConstantHoisting] use BasicBlock::getFirstInsertionPt NFC.Jul 12 2023, 9:40 AM
Closed by commit rG1936bb81aafd: [ConstantHoisting] use BasicBlock::getFirstInsertionPt NFC (authored by nickdesaulniers). · Explain WhyJul 12 2023, 9:51 AM
This revision was automatically updated to reflect the committed changes.
nickdesaulniers added a commit: rG1936bb81aafd: [ConstantHoisting] use BasicBlock::getFirstInsertionPt NFC.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Scalar/
8 lines

Diff 539612

llvm/lib/Transforms/Scalar/ConstantHoisting.cpp

Show First 20 Lines • Show All 317 Lines • ▼ Show 20 LinesSetVector<Instruction *> ConstantHoistingPass::findConstantInsertionPoint(
if (BBs.count(Entry)) { if (BBs.count(Entry)) {
InsertPts.insert(&Entry->front()); InsertPts.insert(&Entry->front());
return InsertPts; return InsertPts;
} }
if (BFI) { if (BFI) {
findBestInsertionSet(*DT, *BFI, Entry, BBs); findBestInsertionSet(*DT, *BFI, Entry, BBs);
for (auto *BB : BBs) { for (BasicBlock *BB : BBs)
BasicBlock::iterator InsertPt = BB->begin(); InsertPts.insert(&*BB->getFirstInsertionPt());
for (; isa<PHINode>(InsertPt) || InsertPt->isEHPad(); ++InsertPt)
;
InsertPts.insert(&*InsertPt);
}
return InsertPts; return InsertPts;
} }
while (BBs.size() >= 2) { while (BBs.size() >= 2) {
BasicBlock *BB, *BB1, *BB2; BasicBlock *BB, *BB1, *BB2;
BB1 = BBs.pop_back_val(); BB1 = BBs.pop_back_val();
BB2 = BBs.pop_back_val(); BB2 = BBs.pop_back_val();
BB = DT->findNearestCommonDominator(BB1, BB2); BB = DT->findNearestCommonDominator(BB1, BB2);
▲ Show 20 Lines • Show All 659 Lines • Show Last 20 Lines