This is an archive of the discontinued LLVM Phabricator instance.

[clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp
ClosedPublic

Authored by mboehme on Jul 11 2023, 5:09 AM.

Details

Summary

These simplify the code in their own right, but they are also useful in that they minimize the number of changes that will need to be made when then API of AggregateStorageLocation and StructValue changes as part of the migration to strict handling of value categories (see https://discourse.llvm.org/t/70086).

Depends On D154949

Diff Detail

Event Timeline

mboehme created this revision.Jul 11 2023, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 5:09 AM
mboehme requested review of this revision.Jul 11 2023, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 5:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mboehme edited the summary of this revision. (Show Details)Jul 11 2023, 5:10 AM
mboehme added reviewers: ymandel, xazax.hun.
mboehme added inline comments.
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp
400–401

This works because we know that constructor has already created a fresh value for E.

gribozavr2 accepted this revision.Jul 11 2023, 6:45 AM
This revision is now accepted and ready to land.Jul 11 2023, 6:45 AM
xazax.hun accepted this revision.Jul 11 2023, 7:27 AM
This revision was landed with ongoing or failed builds.Jul 11 2023, 9:53 PM
This revision was automatically updated to reflect the committed changes.