This is an archive of the discontinued LLVM Phabricator instance.

MIPS: setMaxAtomicSizeInBitsSupported to 32 for MIPS I
AbandonedPublic

Authored by wzssyqa on Jul 6 2023, 3:00 AM.

Details

Reviewers
MaskRay
brad
Summary

Since MIPS II, ldc1/sdc1 instructions introduced, which can be used
to load/store double float. And, in fact they can also be used to
load/store int64 by MEM <-> FPR <-> GPR on 32 bit CPU.

MIPS I has no ldc1/sdc1, so we have to use __atomic_load/store_*.

We don't setMaxAtomicSizeInBitsSupported(0), due to that the MIPS I ISA
suffers from load delay slot: setMaxAtomicSizeInBitsSupported(32) will add nop for it,
while setMaxAtomicSizeInBitsSupported(0) won't.

Fixes: #61166.

Diff Detail

Event Timeline

wzssyqa created this revision.Jul 6 2023, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 3:00 AM
wzssyqa requested review of this revision.Jul 6 2023, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 3:00 AM
wzssyqa added a reviewer: brad.

It is from the version of brad: https://reviews.llvm.org/D141189

I am unfortunately not familiar with Mips. Perhaps you can add some folks who have replied on D141189?

Well your diff doesn't do what you say it does

wzssyqa retitled this revision from MIPS: setMaxAtomicSizeInBitsSupported to 0 for MIPS I to MIPS: setMaxAtomicSizeInBitsSupported to 0 for MIPS 32.Jul 9 2023, 10:10 PM
wzssyqa edited the summary of this revision. (Show Details)
wzssyqa updated this revision to Diff 538505.Jul 9 2023, 10:20 PM
wzssyqa retitled this revision from MIPS: setMaxAtomicSizeInBitsSupported to 0 for MIPS 32 to MIPS: setMaxAtomicSizeInBitsSupported to 32 for MIPS I.

How can I close this differential?

How can I close this differential?

By closing, do you mean abandoning? I hope that @brad and @jrtc27 can make a suggestion.

How can I close this differential?

By closing, do you mean abandoning? I hope that @brad and @jrtc27 can make a suggestion.

Yes. As a new/much better patch has been submitted by brad and then accepted.

brad added a comment.Jul 30 2023, 12:03 AM

How can I close this differential?

If you go to the bottom there is an option, Abandon Revision.

wzssyqa abandoned this revision.Aug 15 2023, 12:55 AM