This is an archive of the discontinued LLVM Phabricator instance.

Differential D154453

[mlir][emitc][nfc] Update summary of opaque type
ClosedPublic

Authored by marbre on Jul 4 2023, 9:29 AM.

Details

Reviewers
jpienaar
mehdi_amini
nicolasvasilache
Commits
rGd954d9758a4f: [mlir][emitc][nfc] Update summary of opaque type
Summary

With this patch error messages are improved. So far, error messages like
operand #0 must An opaque type can be generated.

Diff Detail

Event Timeline

marbre created this revision.Jul 4 2023, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2023, 9:29 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
marbre requested review of this revision.Jul 4 2023, 9:29 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJul 4 2023, 9:29 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B243053: Diff 537119.Jul 4 2023, 9:45 AM
jpienaar accepted this revision.Jul 4 2023, 11:33 AM
This revision is now accepted and ready to land.Jul 4 2023, 11:33 AM
Closed by commit rGd954d9758a4f: [mlir][emitc][nfc] Update summary of opaque type (authored by marbre). · Explain WhyJul 4 2023, 11:36 AM
This revision was automatically updated to reflect the committed changes.
marbre added a commit: rGd954d9758a4f: [mlir][emitc][nfc] Update summary of opaque type.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
EmitC/
IR/
2 lines

Diff 537141

mlir/include/mlir/Dialect/EmitC/IR/EmitCTypes.td

Show All 21 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
class EmitC_Type<string name, string typeMnemonic> class EmitC_Type<string name, string typeMnemonic>
: TypeDef<EmitC_Dialect, name> { : TypeDef<EmitC_Dialect, name> {
let mnemonic = typeMnemonic; let mnemonic = typeMnemonic;
} }
def EmitC_OpaqueType : EmitC_Type<"Opaque", "opaque"> { def EmitC_OpaqueType : EmitC_Type<"Opaque", "opaque"> {
let summary = "An opaque type"; let summary = "EmitC opaque type";
let description = [{ let description = [{
An opaque data type of which the value gets emitted as is. An opaque data type of which the value gets emitted as is.
Example: Example:
```mlir ```mlir
!emitc.opaque<"int"> !emitc.opaque<"int">
Show All 37 Lines