This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Implement GlobalIsel for llvm.get.fpenv
Needs RevisionPublic

Authored by vjayakum on Jun 29 2023, 12:22 PM.

Details

Reviewers
arsenm
bcahoon

Diff Detail

Event Timeline

vjayakum created this revision.Jun 29 2023, 12:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2023, 12:22 PM
vjayakum requested review of this revision.Jun 29 2023, 12:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2023, 12:22 PM
arsenm added inline comments.Jun 29 2023, 1:13 PM
llvm/include/llvm/Support/TargetOpcodes.def
625

Typo environmet

llvm/include/llvm/Target/GenericOpcodes.td
992

Typo environmet

llvm/test/CodeGen/AMDGPU/llvm.get.fpenv.ll
8

I assume something weird happened in the diff, but the test should just add run lines to the existing test. the dag tests should also use an explicit -global-isel=0

arsenm requested changes to this revision.Jul 11 2023, 12:31 PM

I apparently implemented the wrong function, can you split this into adding the G_* opcodes and the IR translation separately?

This revision now requires changes to proceed.Jul 11 2023, 12:31 PM