I did a manual review after the post-review comments in D149543
Details
Details
- Reviewers
philnik ldionne - Group Reviewers
Restricted Project - Commits
- rG285e1e2a0020: [libc++][format] Removes unneeded includes.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
It might require some more exports in the module map, that should be more apparent after D153832
Comment Actions
I expect it helps a bit, I'm not convinced this solves the vector issue. I have another patch, but I expect that one not to be enough either. If that doesn't help we can not include <__format/*.h> when using C++ < 23 (basically what Hans already proposed). That will solve it for older language versions. When people start to use C++23 they will either have to bite the bullet or start using modules.