This is an archive of the discontinued LLVM Phabricator instance.

Monospace font for control flow dot graphs
ClosedPublic

Authored by mark-sed on Jun 29 2023, 8:33 AM.

Details

Summary

This is 1/3 changes to the CFG pass that aims to make graphs more readable and contain more information.

This change sets the font to monospace font since almost all programmers are used to these fonts being used for code and makes it thus more readable than the current sans font.

If all 3 changes will be accepted the final graphs should look as in the attached image:

Diff Detail

Event Timeline

mark-sed created this revision.Jun 29 2023, 8:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2023, 8:33 AM
mark-sed requested review of this revision.Jun 29 2023, 8:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2023, 8:33 AM
mark-sed edited the summary of this revision. (Show Details)Jun 29 2023, 8:44 AM
knaumov accepted this revision.Jul 12 2023, 3:17 PM

LGTM

This revision is now accepted and ready to land.Jul 12 2023, 3:17 PM

I don't have commit rights, could I get someone to commit this for me please?

This revision was automatically updated to reflect the committed changes.