Page MenuHomePhabricator

knaumov (Kirill Naumov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2019, 12:00 PM (10 w, 3 d)

Recent Activity

Today

knaumov updated the diff for D73142: Heat Coloring for CFGPrinter and CallPrinter.

Changes:

  • Renamed a flag ("callgraph-full" -> "call-multigraph") to reflect its purpose more clearly
  • Removed unnecessary if-check
  • General refactoring and restructuring
  • Removed useHeuristic from the code - from the structure of the code it is vivid that useHeuristic variable used in getMaxFreq functions is always set to "true" and never becomes "false".
Mon, Feb 24, 11:25 AM · Restricted Project

Fri, Feb 21

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Fixed small inaccuracies
As the patch is done, @apilipenko , can you please push it for me?

Fri, Feb 21, 2:48 PM · Restricted Project
knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Sorry, wrong diff

Fri, Feb 21, 2:48 PM · Restricted Project

Thu, Feb 20

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Addressed @apilipenko 's comments

  • Switched to one flag
  • Small changes in struct and comments
Thu, Feb 20, 4:55 PM · Restricted Project

Thu, Feb 13

knaumov added a comment to D73142: Heat Coloring for CFGPrinter and CallPrinter.

ping

Thu, Feb 13, 6:53 AM · Restricted Project

Wed, Feb 12

knaumov added a comment to D74346: Flags for displaying only hot nodes in CFGPrinter graph.

Replying to @davidxl
This option is useful when you are analyzing only the "hot" paths on the CFG.
Using these flags you are getting rid of all the unnecessary paths in the graph (the ones that end in deopt or are unreachable)

Wed, Feb 12, 1:47 PM · Restricted Project
knaumov updated the diff for D74346: Flags for displaying only hot nodes in CFGPrinter graph.

Resolving @apilipenko 's suggestions
As I don't have commit access, can you please commit the change for me?

Wed, Feb 12, 1:38 PM · Restricted Project

Mon, Feb 10

knaumov created D74346: Flags for displaying only hot nodes in CFGPrinter graph.
Mon, Feb 10, 10:27 AM · Restricted Project
knaumov added a comment to D71501: Cost Annotation Writer for InlineCost.

ping

Mon, Feb 10, 6:58 AM · Restricted Project

Mon, Feb 3

knaumov updated the diff for D73142: Heat Coloring for CFGPrinter and CallPrinter.

Addressed @davidxl and @sfertile comments.

Mon, Feb 3, 2:28 PM · Restricted Project
knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Resolving @apilipenko suggestions.
Removed deltas from the struct.

Mon, Feb 3, 10:41 AM · Restricted Project

Tue, Jan 28

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Changed unnecessarily complicated test

Tue, Jan 28, 12:35 PM · Restricted Project

Mon, Jan 27

knaumov added a comment to D73142: Heat Coloring for CFGPrinter and CallPrinter.

ping

Mon, Jan 27, 11:25 AM · Restricted Project
knaumov added a comment to D71501: Cost Annotation Writer for InlineCost.

ping

Mon, Jan 27, 11:25 AM · Restricted Project

Jan 21 2020

knaumov created D73142: Heat Coloring for CFGPrinter and CallPrinter.
Jan 21 2020, 2:32 PM · Restricted Project
knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Answering @mtrofin comments.
Refactoring, little changes:

  • Separated the initial flag into two: one prints the whole info on instruction cost and threshold, the other one prints only deltas of cost and threshold
  • Changed the InlineCostDetail structure - introduced CostBefore, CostAfter, CostDelta, ThresholdBefore, ThresholdAfter, ThresholdDelta
  • Changed the test that I wrote to match the check of new flags
  • Little comment changes
Jan 21 2020, 10:10 AM · Restricted Project

Jan 17 2020

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Changed pait<int, int> to struct InlineCostDetails in DenseMap and changed comment defining CostThrehsoldMap.
@mtrofin : Yes, the DenseMap stores the delta of the cost and threshold after inlining the instruction, not just a snapshot.
This is done in order to see the exact cost/change in the threshold it would take to inline the instruction.

Jan 17 2020, 3:02 PM · Restricted Project

Jan 16 2020

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Sorry for the delay due to the changes in structure of InlineCost.cpp in this patch: https://reviews.llvm.org/D71733 .
Structural changes mostly.
Added test to llvm/test/DebugInfo to test the new flag.

Jan 16 2020, 12:28 PM · Restricted Project

Jan 7 2020

knaumov added a comment to D71501: Cost Annotation Writer for InlineCost.

ping

Jan 7 2020, 9:08 AM · Restricted Project

Dec 16 2019

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Refactoring

Dec 16 2019, 5:03 PM · Restricted Project

Dec 13 2019

knaumov created D71501: Cost Annotation Writer for InlineCost.
Dec 13 2019, 6:12 PM · Restricted Project