Page MenuHomePhabricator

knaumov (Kirill Naumov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2019, 12:00 PM (40 w, 2 d)

Recent Activity

Jun 25 2020

knaumov committed rGd48c7859fbb9: [InlineCost] GetElementPtr with constant operands (authored by knaumov).
[InlineCost] GetElementPtr with constant operands
Jun 25 2020, 11:21 AM

Jun 24 2020

knaumov committed rG7f094f7f9d3e: [InlineCost] PrinterPass prints constants to which instructions are simplified (authored by knaumov).
[InlineCost] PrinterPass prints constants to which instructions are simplified
Jun 24 2020, 4:20 PM
knaumov abandoned D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis.

The change landed: https://github.com/llvm/llvm-project/commit/6a5d7d498c0b16b13ace802f422b223eb510c303

Jun 24 2020, 3:13 PM · Restricted Project
knaumov committed rG6a5d7d498c0b: [InlineCost] InlineCostAnnotationWriterPass introduced (authored by knaumov).
[InlineCost] InlineCostAnnotationWriterPass introduced
Jun 24 2020, 2:41 PM
knaumov committed rGca899bf90aca: [InlineCost] Added InlineCostCallAnalyzer::print() (authored by knaumov).
[InlineCost] Added InlineCostCallAnalyzer::print()
Jun 24 2020, 1:35 PM
knaumov closed D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds.
Jun 24 2020, 1:35 PM · Restricted Project
knaumov added a comment to D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds.

ping

Jun 24 2020, 11:55 AM · Restricted Project

Jun 22 2020

knaumov updated the diff for D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds.
  • Because print() performs the same functionality as did dump(), instead of copying the code just call print() from dump()
Jun 22 2020, 11:50 AM · Restricted Project
knaumov updated the diff for D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds.
  • To avoid redundancy, used the preprocessing function DEBUG_PRINT_STAT defined for ::dump()
Jun 22 2020, 11:17 AM · Restricted Project

Jun 19 2020

knaumov added a comment to D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis.

All of the preparational patches were approved, but there was an issue with integration which is being resolved in D82205

Jun 19 2020, 4:19 PM · Restricted Project
knaumov added a comment to D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds.

Answering @mtrofin :
Although what you suggested is a valid solution, it will go against the point of this whole pass - to enable the checks of inliner's inner works for all builds, not just the debug ones. If we apply your solution, then still we will get several builds which will avoid being checked due to the conditioning flags.

Jun 19 2020, 1:04 PM · Restricted Project
knaumov closed D81321: Compatibility of AnnotationWriter with BasicBlock Class.

Closed due to commit: https://github.com/llvm/llvm-project/commit/41d53194fb9d5aba3e4861233b1af9cb62cc999a

Jun 19 2020, 10:52 AM · Restricted Project
knaumov created D82205: InlineCost - method ::print() to allow dump of statistics to non-debug builds.
Jun 19 2020, 10:19 AM · Restricted Project

Jun 18 2020

knaumov committed rG41d53194fb9d: [BasicBlock] Added AnnotationWriter functionality to BasicBlock class (authored by knaumov).
[BasicBlock] Added AnnotationWriter functionality to BasicBlock class
Jun 18 2020, 1:09 PM

Jun 17 2020

knaumov committed rGea844c75207a: Revert "[InlineCost] InlineCostAnnotationWriterPass introduced" (authored by knaumov).
Revert "[InlineCost] InlineCostAnnotationWriterPass introduced"
Jun 17 2020, 7:32 AM
knaumov committed rG39a4505e3438: Revert "[InlineCost] GetElementPtr with constant operands" (authored by knaumov).
Revert "[InlineCost] GetElementPtr with constant operands"
Jun 17 2020, 7:32 AM
knaumov committed rGdcf2a9f2ee3a: Revert "[InlineCost] PrinterPass prints constants to which instructions are… (authored by knaumov).
Revert "[InlineCost] PrinterPass prints constants to which instructions are…
Jun 17 2020, 7:32 AM
knaumov added a reverting change for rG37e06e8f5c6e: [InlineCost] InlineCostAnnotationWriterPass introduced: rGea844c75207a: Revert "[InlineCost] InlineCostAnnotationWriterPass introduced".
Jun 17 2020, 7:32 AM
knaumov added a reverting change for rG34fba68d8005: [InlineCost] GetElementPtr with constant operands: rG39a4505e3438: Revert "[InlineCost] GetElementPtr with constant operands".
Jun 17 2020, 7:32 AM
knaumov added a reverting change for rG52b0db22f8cf: [InlineCost] PrinterPass prints constants to which instructions are simplified: rGdcf2a9f2ee3a: Revert "[InlineCost] PrinterPass prints constants to which instructions are….
Jun 17 2020, 7:32 AM
knaumov committed rG34fba68d8005: [InlineCost] GetElementPtr with constant operands (authored by knaumov).
[InlineCost] GetElementPtr with constant operands
Jun 17 2020, 6:59 AM
knaumov committed rG37e06e8f5c6e: [InlineCost] InlineCostAnnotationWriterPass introduced (authored by knaumov).
[InlineCost] InlineCostAnnotationWriterPass introduced
Jun 17 2020, 6:59 AM
knaumov committed rG52b0db22f8cf: [InlineCost] PrinterPass prints constants to which instructions are simplified (authored by knaumov).
[InlineCost] PrinterPass prints constants to which instructions are simplified
Jun 17 2020, 6:59 AM
knaumov closed D81026: Inline Cost improvement - GetElementPtr with constant operands.
Jun 17 2020, 6:59 AM · Restricted Project
knaumov closed D81024: InlineCostAnnotationPrinterPass - print constants to which instructions are simplified.
Jun 17 2020, 6:58 AM · Restricted Project
knaumov closed D81743: InlineCostAnnotationPrinterPass - Introducing the pass.
Jun 17 2020, 6:58 AM · Restricted Project
knaumov added a comment to D77161: Heat Coloring (2/3): Adding Heat Functionality to CFGPrinter.

Addressed to @kbobyrev:
Thank you for the detailed report! I will add new assert/verification code to cover the point you discussed.

Jun 17 2020, 6:58 AM · Restricted Project

Jun 16 2020

knaumov updated the summary of D81743: InlineCostAnnotationPrinterPass - Introducing the pass.
Jun 16 2020, 3:23 PM · Restricted Project
knaumov added a comment to D81024: InlineCostAnnotationPrinterPass - print constants to which instructions are simplified.

ping

Jun 16 2020, 2:51 PM · Restricted Project
knaumov abandoned D73142: Heat Coloring for CFGPrinter and CallPrinter.

All of the related patches were successfully reviewed and landed!
Thanks to everyone who has participated in this long journey!

Jun 16 2020, 2:50 PM · Restricted Project
knaumov closed D49154: Extend CFGPrinter and CallPrinter with Heat Colors: Polly changes.

This change was implemented as a part of Heat Coloring (1/3): Adding distinct structure for CFGDOTInfo (D76820). Closed by commit https://reviews.llvm.org/rG3f995ce8b54ca6094fd47a5f1090ef6ce367ded2

Jun 16 2020, 2:50 PM
knaumov updated the diff for D81743: InlineCostAnnotationPrinterPass - Introducing the pass.
  • Changed the comments to better reflect the usage of the pass
  • Changed the summary of the differential
Jun 16 2020, 2:50 PM · Restricted Project
knaumov committed rG369d00df60dc: [CallPrinter] Adding heat coloring to CallPrinter (authored by knaumov).
[CallPrinter] Adding heat coloring to CallPrinter
Jun 16 2020, 2:22 PM
knaumov closed D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.
Jun 16 2020, 2:22 PM · Restricted Project
knaumov updated the diff for D81743: InlineCostAnnotationPrinterPass - Introducing the pass.

Sorry, submitted wrong diff

Jun 16 2020, 7:42 AM · Restricted Project
knaumov updated the diff for D81743: InlineCostAnnotationPrinterPass - Introducing the pass.
  • Refactored the comment

For now, my view of the pass is to be able to tell what optimizations are seen and predicted by InlineCost. E.g. is a follow-up patch D81024 which enables printing of constants to which the instruction will be simplified. For now, if you've written a simplification for InlineCost that constant-folds some sequence of instructions, you have no way of writing test for it except by setting the inline threshold so low, so the fact of simplification will inline the method. This pass provides an easy way to see such cases directly. Also, the fact of simplification itself is independent of InlineParams, so the pass would work as expected.

Jun 16 2020, 7:42 AM · Restricted Project

Jun 15 2020

knaumov updated the diff for D81026: Inline Cost improvement - GetElementPtr with constant operands.
  • Added flag for the change which is true by default

I have been struggling to collect the data @mtrofin has asked for to prove the usefulness of the patch. I will continue to do so, but meanwhile, I suggest accepting the change. Once I have gathered needed data, I will post new differential presenting the results and (most likely) deleting the flag.

Jun 15 2020, 7:19 PM · Restricted Project
knaumov added a comment to D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

ping

Jun 15 2020, 11:31 AM · Restricted Project

Jun 12 2020

knaumov updated the diff for D81743: InlineCostAnnotationPrinterPass - Introducing the pass.

Changed the creation of InlineParams back to default params and added a "to-do" comment.
For the purposes of this pass, the idea of which is to give access for non-debug builds to tests that use debug functionality, the InlineParams can be taken as default. My suggestion is to leave the extension of the pass to parametrization with different InlineParams as a "to-do" for now.

Jun 12 2020, 12:35 PM · Restricted Project
knaumov added a comment to D81743: InlineCostAnnotationPrinterPass - Introducing the pass.

A question to @mtrofin:
I have changed the creation of InlineParams from

const InlineParams Params = llvm::getInlineParams();

which invokes the creation of InlineParams with DefaultThreshold to

Jun 12 2020, 8:03 AM · Restricted Project
knaumov created D81743: InlineCostAnnotationPrinterPass - Introducing the pass.
Jun 12 2020, 8:03 AM · Restricted Project

Jun 11 2020

knaumov closed D81687: InlineCostAnnotationPrinterPass - preparational patch. Renaming structs, renaming flag, refactoring.

Closed due to this commit: https://github.com/llvm/llvm-project/commit/1022b5eb5b37f7dc93ae36002de694541db0e0c1

Jun 11 2020, 4:33 PM · Restricted Project
knaumov committed rG1022b5eb5b37: [InlineCost] Preparational patch for creation of Printer pass. (authored by knaumov).
[InlineCost] Preparational patch for creation of Printer pass.
Jun 11 2020, 4:00 PM
knaumov created D81687: InlineCostAnnotationPrinterPass - preparational patch. Renaming structs, renaming flag, refactoring.
Jun 11 2020, 1:47 PM · Restricted Project

Jun 10 2020

knaumov added a comment to D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis.

Ping

Jun 10 2020, 1:55 PM · Restricted Project

Jun 5 2020

knaumov created D81321: Compatibility of AnnotationWriter with BasicBlock Class.
Jun 5 2020, 6:27 PM · Restricted Project

Jun 4 2020

knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

I have noticed that MaxEdgeCount is essentially count the same thing as MaxFreq, so I replaced its uses in all the cases.

Jun 4 2020, 12:09 PM · Restricted Project

Jun 3 2020

knaumov updated the diff for D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis.

Addressed @mtrofin 's comments:

    • Before the change, we had CostAnnotationWriter that was used just to display the cost difference per instruction, hence the CostThresholdMap (which now became InstructionCostDetailMap) was in the printer itself. Now, the change changed that by putting the map into InlineCostCallAnalyzer to keep all the data in this class.
  • The move of code was unnecessary, changed it
Jun 3 2020, 10:25 AM · Restricted Project
knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

Addressed @davidxl 's comments:

  • Added comments
  • Brought for-loop iteration over functions in the module into the previous one
Jun 3 2020, 7:38 AM · Restricted Project

Jun 2 2020

knaumov updated the diff for D81026: Inline Cost improvement - GetElementPtr with constant operands.

Answering @mtrofin 's comments:

Jun 2 2020, 1:43 PM · Restricted Project
knaumov created D81026: Inline Cost improvement - GetElementPtr with constant operands.
Jun 2 2020, 12:37 PM · Restricted Project
knaumov created D81024: InlineCostAnnotationPrinterPass - print constants to which instructions are simplified.
Jun 2 2020, 12:05 PM · Restricted Project
knaumov updated the diff for D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis.
  • Refactoring change
Jun 2 2020, 10:25 AM · Restricted Project
knaumov created D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis.
Jun 2 2020, 10:25 AM · Restricted Project

May 27 2020

knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

Addressed @davidxl 's comments, did some refactoring

May 27 2020, 1:02 PM · Restricted Project

May 4 2020

knaumov added a comment to D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

This Callgraph was generated from test_heat.ll
You can see, as foo is not being called by anyone, it is marked as the coldest block. Bar functions are ranked from the least number to the greatest by their hotness which makes sense - whenever function bar1 is called, it is calling all of the other bars that follow and so on. Thus, bar5 is the hottest function in the .ll file

May 4 2020, 7:59 AM · Restricted Project

May 1 2020

knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.
  • Fixed the functionality of heat coloring - now the coloring of CallGraph is done by analyzing how many times the given function was called. The more times it's being called - the hotter ("redder") it will be on the graph.
May 1 2020, 5:08 PM · Restricted Project

Apr 30 2020

knaumov committed rG0383253cdfe7: [InlineCost] Addressing a very strict assert check in CostAnnotationWriter… (authored by knaumov).
[InlineCost] Addressing a very strict assert check in CostAnnotationWriter…
Apr 30 2020, 9:03 AM
knaumov closed D79107: Addressing a very strict assert check in CostAnnotationWriter::emitInstructionAnnot.
Apr 30 2020, 9:02 AM · Restricted Project
knaumov added a comment to rG0fa793e79870: Revert "[InlineCost] Addressing a very strict assert check in….

This revert was necessary as the test used "-debug-only" option without

; Require asserts for -debug-only
; REQUIRES: asserts
Apr 30 2020, 8:29 AM
knaumov closed D79110: Turning on Heat Colors for CFG by default.

Closing due to commit: https://github.com/llvm/llvm-project/commit/055f58fcfc618cdad0a8cb66fbd4657cdc0d05e9

Apr 30 2020, 8:29 AM · Restricted Project

Apr 29 2020

knaumov committed rG0fa793e79870: Revert "[InlineCost] Addressing a very strict assert check in… (authored by knaumov).
Revert "[InlineCost] Addressing a very strict assert check in…
Apr 29 2020, 3:07 PM
knaumov added a reverting change for rG66947d05fd19: [InlineCost] Addressing a very strict assert check in CostAnnotationWriter…: rG0fa793e79870: Revert "[InlineCost] Addressing a very strict assert check in….
Apr 29 2020, 3:07 PM
knaumov committed rG055f58fcfc61: [CFG] Turning on Heat Colors for CFG by default (authored by knaumov).
[CFG] Turning on Heat Colors for CFG by default
Apr 29 2020, 2:01 PM
knaumov committed rG66947d05fd19: [InlineCost] Addressing a very strict assert check in CostAnnotationWriter… (authored by knaumov).
[InlineCost] Addressing a very strict assert check in CostAnnotationWriter…
Apr 29 2020, 2:01 PM
knaumov created D79110: Turning on Heat Colors for CFG by default.
Apr 29 2020, 11:49 AM · Restricted Project
knaumov updated the summary of D79107: Addressing a very strict assert check in CostAnnotationWriter::emitInstructionAnnot.
Apr 29 2020, 11:18 AM · Restricted Project
knaumov created D79107: Addressing a very strict assert check in CostAnnotationWriter::emitInstructionAnnot.
Apr 29 2020, 11:16 AM · Restricted Project

Apr 20 2020

knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.
  • Changed the flag in the test
Apr 20 2020, 2:38 PM · Restricted Project

Apr 13 2020

knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

The wrong diff uploaded previously, reupload

Apr 13 2020, 2:47 PM · Restricted Project
knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

Answering @davidxl 's comments:

  • Renamed flags
Apr 13 2020, 2:42 PM · Restricted Project

Apr 10 2020

knaumov updated the diff for D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.

Transferred the getNumOfCalls functions from the previous review.

Apr 10 2020, 9:56 AM · Restricted Project

Apr 9 2020

knaumov committed rG6f85ec960be4: [Tools] Fixed bug with llvm/utils/chunk-print-before-all.py script. (authored by knaumov).
[Tools] Fixed bug with llvm/utils/chunk-print-before-all.py script.
Apr 9 2020, 3:31 PM
knaumov closed D76507: Bug in llvm/utils/print-before-all.py script, fails to compile chunk-0.ll.
Apr 9 2020, 3:30 PM · Restricted Project
knaumov accepted D77762: [llvm][nfc] InstructionCostDetail encapsulation.

LGTM

Apr 9 2020, 8:07 AM · Restricted Project

Apr 8 2020

knaumov committed rG8b67853a83c1: [CFGPrinter] Adding heat coloring to CFGPrinter (authored by knaumov).
[CFGPrinter] Adding heat coloring to CFGPrinter
Apr 8 2020, 1:03 PM
knaumov closed D77161: Heat Coloring (2/3): Adding Heat Functionality to CFGPrinter.
Apr 8 2020, 1:03 PM · Restricted Project
knaumov committed rG0125db9ab21d: [TimePasses] Small fix in "-time-passes" flag that makes it more stable (authored by knaumov).
[TimePasses] Small fix in "-time-passes" flag that makes it more stable
Apr 8 2020, 9:13 AM
knaumov closed D76946: Start using StringMap for TimingData.
Apr 8 2020, 9:13 AM · Restricted Project

Apr 7 2020

knaumov updated the summary of D76507: Bug in llvm/utils/print-before-all.py script, fails to compile chunk-0.ll.
Apr 7 2020, 6:00 PM · Restricted Project

Apr 6 2020

knaumov committed rG3f995ce8b54c: [CFGPrinter][CallPrinter][polly] Adding distinct structure for CFGDOTInfo (authored by knaumov).
[CFGPrinter][CallPrinter][polly] Adding distinct structure for CFGDOTInfo
Apr 6 2020, 10:53 AM
knaumov closed D76820: Heat Coloring (1/3): Adding distinct structure for CFGDOTInfo.
Apr 6 2020, 10:52 AM · Restricted Project

Apr 1 2020

knaumov updated the diff for D77161: Heat Coloring (2/3): Adding Heat Functionality to CFGPrinter.

Answering @davidxl 's comments:

  • Fixed the introduction of getNumOfCalls methods.
  • Concerning the color-blind accessibility - from my research, I have found that the combination of blue and red and all of the intermediate colors are well perceived by the majority of types of color-blind people. I have not found a way to make edges of the boxes gradually bolder to reflect the gradation from cold to hot methods. If any such solutions were to be found, it would be great to implement them, but my suggestion is to do it as a separate future patch while the current series of patches introduces only necessary functionality.
  • Clang-Format: I have applied the clang-format on the said file and found out that not only my changes were formatted, but most of the original file as well. I have reverted the clang-format, as it makes the diff big and hard to follow. Of course, once I am going to be pushing the changes, I will apply clang-format over all the files that were altered by my patches.
Apr 1 2020, 1:09 PM · Restricted Project

Mar 31 2020

knaumov updated the summary of D77161: Heat Coloring (2/3): Adding Heat Functionality to CFGPrinter.
Mar 31 2020, 2:17 PM · Restricted Project
knaumov created D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter.
Mar 31 2020, 2:17 PM · Restricted Project
knaumov created D77161: Heat Coloring (2/3): Adding Heat Functionality to CFGPrinter.
Mar 31 2020, 12:33 PM · Restricted Project

Mar 30 2020

knaumov added a comment to D76820: Heat Coloring (1/3): Adding distinct structure for CFGDOTInfo.

Excellent!
Can anyone with the commit access make a push of this patch?

Mar 30 2020, 10:16 AM · Restricted Project
knaumov updated the diff for D76820: Heat Coloring (1/3): Adding distinct structure for CFGDOTInfo.

Renamed the structure:
CFGDOTInfo -> DOTFuncInfo

Mar 30 2020, 9:10 AM · Restricted Project
knaumov added a comment to D76507: Bug in llvm/utils/print-before-all.py script, fails to compile chunk-0.ll.

Ping

Mar 30 2020, 7:33 AM · Restricted Project

Mar 27 2020

knaumov created D76946: Start using StringMap for TimingData.
Mar 27 2020, 12:36 PM · Restricted Project

Mar 25 2020

knaumov updated the summary of D76820: Heat Coloring (1/3): Adding distinct structure for CFGDOTInfo.
Mar 25 2020, 7:30 PM · Restricted Project
knaumov created D76820: Heat Coloring (1/3): Adding distinct structure for CFGDOTInfo.
Mar 25 2020, 7:30 PM · Restricted Project

Mar 20 2020

knaumov created D76507: Bug in llvm/utils/print-before-all.py script, fails to compile chunk-0.ll.
Mar 20 2020, 9:10 AM · Restricted Project
knaumov added a comment to D73142: Heat Coloring for CFGPrinter and CallPrinter.

Ping

Mar 20 2020, 7:32 AM · Restricted Project

Mar 6 2020

knaumov updated the diff for D73142: Heat Coloring for CFGPrinter and CallPrinter.

Fixes:

  • Added documentation to the new functions
  • Added two test cases - one for multigraph, the second one for heat CallGraph/CFG specifically
  • Reduced the quadratic behavior that was mentioned by @davidxl . There is no way to reduce the behavior to smaller than O(n^2), but I've made it to (n^2)/2. There is no need to go beyond this as this is just a debugging feature that is not to be used outside of debugging.
Mar 6 2020, 10:28 AM · Restricted Project

Feb 28 2020

knaumov updated the diff for D73142: Heat Coloring for CFGPrinter and CallPrinter.
  • Restoring the effect of clang-format

The effect of clang-format was restored for better readability of the patch

  • Deleted Heuristic fully

As I said in the previous diffs, Heuristic bool was always true and never changing.

  • Transferred CFGPrinter back to Function Pass

The patch was made module in order to implement the comparison between BB across functions. As this patch is not targeting this behavior, the pass was decided to remain Function Pass

  • Small stylistics changes
Feb 28 2020, 1:42 PM · Restricted Project

Feb 25 2020

knaumov updated the diff for D73142: Heat Coloring for CFGPrinter and CallPrinter.
  • Removed flag that was targeting coloring BB based on their relative hotness across the module.

I have decided to do that for the following reasons:

  1. The patch is self-contained without this feature. This feature can be added in a follow-up patch.
  2. The feature itself is not as important and valuable as was first thought of.
Feb 25 2020, 12:40 PM · Restricted Project

Feb 24 2020

knaumov updated the diff for D73142: Heat Coloring for CFGPrinter and CallPrinter.

Changes:

  • Renamed a flag ("callgraph-full" -> "call-multigraph") to reflect its purpose more clearly
  • Removed unnecessary if-check
  • General refactoring and restructuring
  • Removed useHeuristic from the code - from the structure of the code it is vivid that useHeuristic variable used in getMaxFreq functions is always set to "true" and never becomes "false".
Feb 24 2020, 11:25 AM · Restricted Project

Feb 21 2020

knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Fixed small inaccuracies
As the patch is done, @apilipenko , can you please push it for me?

Feb 21 2020, 2:48 PM · Restricted Project
knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Sorry, wrong diff

Feb 21 2020, 2:48 PM · Restricted Project