This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Convert test to opaque pointers (NFC)
ClosedPublic

Authored by nikic on Jun 28 2023, 1:12 AM.

Diff Detail

Event Timeline

nikic created this revision.Jun 28 2023, 1:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
nikic requested review of this revision.Jun 28 2023, 1:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
nikic added a comment.Jun 28 2023, 1:15 AM

Highlighted the relevant differences.

llvm/test/Transforms/Attributor/nocapture-2.ll
169

We get more returned due to missing bitcasts -- expected.

176

We lost dereferenceable_or_null on @scc_A calls -- it's still present on the declaration though, so no real loss of information. Probably not supposed to happen though?

222

dereferenceable_or_null increase to 8 is correct, because we now recognize that we return the argument, which has a dereferenceable_or_null(8) attribute.

nikic updated this revision to Diff 537107.Jul 4 2023, 8:01 AM

Rebase over more test changes.

jdoerfert accepted this revision.Jul 4 2023, 11:53 AM

LG, sorry I'm changing tests a lot right now.

This revision is now accepted and ready to land.Jul 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.