Improve fatal error message when handling promised interfaces

[mehdi_amini]

Summary

When initializing DialectInterfaceCollection, we wouldn't have the missing
interface name in the error.

mlir/include/mlir/IR/DialectInterface.h

struct InterfaceKeyInfo : public DenseMapInfo<const DialectInterface *> {
     }
   };
 
   /// A set of registered dialect interface instances.
   using InterfaceSetT = DenseSet<const DialectInterface *, InterfaceKeyInfo>;
   using InterfaceVectorT = std::vector<const DialectInterface *>;
 
 public:
-  DialectInterfaceCollectionBase(MLIRContext *ctx, TypeID interfaceKind);
+  DialectInterfaceCollectionBase(MLIRContext *ctx, TypeID interfaceKind,
+                                 StringRef interfaceName);
   virtual ~DialectInterfaceCollectionBase();
 
 protected:
   /// Get the interface for the dialect of given operation, or null if one
   /// is not registered.
   const DialectInterface *getInterfaceFor(Operation *op) const;
 
   /// Get the interface for the given dialect.

 class DialectInterfaceCollection
     : public detail::DialectInterfaceCollectionBase {
 public:
   using Base = DialectInterfaceCollection<InterfaceType>;
 
   /// Collect the registered dialect interfaces within the provided context.
   DialectInterfaceCollection(MLIRContext *ctx)
       : detail::DialectInterfaceCollectionBase(
-            ctx, InterfaceType::getInterfaceID()) {}
+            ctx, InterfaceType::getInterfaceID(),
+            llvm::getTypeName<InterfaceType>()) {}
 
   /// Get the interface for a given object, or null if one is not registered.
   /// The object may be a dialect or an operation instance.
   template <typename Object>
   const InterfaceType *getInterfaceFor(Object *obj) const {
     return static_cast<const InterfaceType *>(
         detail::DialectInterfaceCollectionBase::getInterfaceFor(obj));
   }

mlir/lib/IR/Dialect.cpp

 
 DialectInterface::~DialectInterface() = default;
 
 MLIRContext *DialectInterface::getContext() const {
   return dialect->getContext();
 }
 
 DialectInterfaceCollectionBase::DialectInterfaceCollectionBase(
-    MLIRContext *ctx, TypeID interfaceKind) {
+    MLIRContext *ctx, TypeID interfaceKind, StringRef interfaceName) {
   for (auto *dialect : ctx->getLoadedDialects()) {
+#ifndef NDEBUG
+  dialect->handleUseOfUndefinedPromisedInterface(interfaceKind, interfaceName);
+#endif
     if (auto *interface = dialect->getRegisteredInterface(interfaceKind)) {
       interfaces.insert(interface);
       orderedInterfaces.push_back(interface);
     }
   }
 }
 
 DialectInterfaceCollectionBase::~DialectInterfaceCollectionBase() = default;