[mlir][memref] Add some missing interfaces to memref ops.

[Hardcode84]

Summary

Add ViewLikeOpInterface, to ExtractStridedMetadataOp as it returns its buffer as one of the results.
Add mem Read/write attributes to atomic ops.

[chelini]

mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td

1022

nit: Can you please add some docs here, for example: "the reference to read from and write to".

2256

same here pls.

[Hardcode84]

rebase, fix review comments

mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td

 //===----------------------------------------------------------------------===//
 // ExtractStridedMetadataOp
 //===----------------------------------------------------------------------===//
 
 def MemRef_ExtractStridedMetadataOp : MemRef_Op<"extract_strided_metadata", [
     DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>,
     Pure,
     SameVariadicResultSize,
+    ViewLikeOpInterface,
     DeclareOpInterfaceMethods<InferTypeOpInterface>]> {
   let summary = "Extracts a buffer base with offset and strides";
   let description = [{
     Extracts a base buffer, offset and strides. This op allows additional layers
     of transformations and foldings to be added as lowering progresses from
     higher-level dialect to lower-level dialects such as the LLVM dialect.
 
     The op requires a strided memref source operand. If the source operand is not
let extraClassDeclaration = [{
     /// Similarly if the resulting memref type is `memref<2x?xi16>`, but
     /// `%dyn_size1` can statically be pinned to a constant value, this
     /// constant value is returned instead of `%dyn_size`.
     SmallVector<OpFoldResult> getConstifiedMixedSizes();
     /// Similar to `getConstifiedMixedSizes` but for strides.
     SmallVector<OpFoldResult> getConstifiedMixedStrides();
     /// Similar to `getConstifiedMixedSizes` but for the offset.
     OpFoldResult getConstifiedMixedOffset();
+
+    ::mlir::Value getViewSource() { return getSource(); }
   }];
 
   let hasFolder = 1;
 }
 
 //===----------------------------------------------------------------------===//
 // GenericAtomicRMWOp
 //===----------------------------------------------------------------------===//
%x = memref.generic_atomic_rmw %I[%i] : memref<10xf32> {
         %c1 = arith.constant 1.0 : f32
         %inc = arith.addf %c1, %current_value : f32
         memref.atomic_yield %inc : f32
     }
     ```
   }];
 
   let arguments = (ins
-      MemRefOf<[AnySignlessInteger, AnyFloat]>:$memref,
+      Arg<MemRefOf<[AnySignlessInteger, AnyFloat]>, "the reference to read from and write to", [MemRead, MemWrite]>:$memref,
       Variadic<Index>:$indices);
 
   let results = (outs
       AnyTypeOf<[AnySignlessInteger, AnyFloat]>:$result);
 
   let regions = (region AnyRegion:$atomic_body);
 
   let skipDefaultBuilders = 1;
let description = [{
     ```mlir
     %x = memref.atomic_rmw "addf" %value, %I[%i] : (f32, memref<10xf32>) -> f32
     ```
   }];
 
   let arguments = (ins
       AtomicRMWKindAttr:$kind,
       AnyTypeOf<[AnySignlessInteger, AnyFloat]>:$value,
-      MemRefOf<[AnySignlessInteger, AnyFloat]>:$memref,
+      Arg<MemRefOf<[AnySignlessInteger, AnyFloat]>, "the reference to read from and write to", [MemRead, MemWrite]>:$memref,
       Variadic<Index>:$indices);
   let results = (outs AnyTypeOf<[AnySignlessInteger, AnyFloat]>:$result);
 
   let assemblyFormat = [{
     $kind $value `,` $memref `[` $indices `]` attr-dict `:` `(` type($value) `,`
     type($memref) `)` `->` type($result)
   }];