The existing lowering has lower precision for certain use cases, e.g.
tanh. Improved version should demonstrate an overall higher level of precision.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks! (well and Emilio for his help here too)
mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp | ||
---|---|---|
898 | Nit: clampWithNormals to follow naming convention. | |
900 | lowerBound, upperBound | |
908 | selectCmp | |
935 | You can drop getType here (getElementTypeOrSelf has a Value overload) | |
936 | MLIR style is to elide trivial braces |
Nit: clampWithNormals to follow naming convention.