This is an archive of the discontinued LLVM Phabricator instance.

[lldb][TerminalTest] Fix assertion failure
ClosedPublic

Authored by splhack on Jun 15 2023, 6:02 PM.

Details

Summary

D152712 replaced llvm::sys::RetryAfterSignal(-1, ::open) with
FileSystem::Instance().Open for bionic in PseudoTerminal::OpenSecondary, and
FileSystem::Instance() is failing with assertion on arm Linux.

The assertion should be FileSystem re-initialization check, therefore the
hypothesis is that TerminalTest tests are initializing FileSystem instance
repeatedly.

Use SubsystemRAII<FileSystem> to ensure tearing down the FileSystem instance.

Diff Detail

Event Timeline

splhack created this revision.Jun 15 2023, 6:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 6:02 PM
splhack requested review of this revision.Jun 15 2023, 6:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 6:02 PM
This revision is now accepted and ready to land.Jun 15 2023, 8:22 PM
This revision was automatically updated to reflect the committed changes.