This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix VOPD dependency checks during combine
ClosedPublic

Authored by rampitec on Jun 14 2023, 11:44 AM.

Details

Summary

Check superreg/subreg defs of an instruction when checking for
dependencies. This may cause some regressions, but better be
safe than sorry. Changed tests are affected because of the
implicit-defs of the superregs.

Diff Detail

Event Timeline

rampitec created this revision.Jun 14 2023, 11:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 11:44 AM
rampitec requested review of this revision.Jun 14 2023, 11:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 11:44 AM
Herald added a subscriber: wdng. · View Herald Transcript
foad accepted this revision.Jun 15 2023, 2:41 AM

LGTM.

Changed tests are affected because of the imlict-defs of the superregs.

Ugh, yet another reason to get rid of those implicit defs...

This revision is now accepted and ready to land.Jun 15 2023, 2:41 AM
rampitec edited the summary of this revision. (Show Details)Jun 15 2023, 10:23 AM
This revision was automatically updated to reflect the committed changes.