This is an archive of the discontinued LLVM Phabricator instance.

clang: Add start of header test for __clang_hip_libdevice_declares
ClosedPublic

Authored by arsenm on Jun 13 2023, 9:43 AM.

Details

Summary

It was shockingly difficult to get identical checks out of the 3
languages. The visibility, dso_local and fp-contract settings seem to
differ unless I force every test function to
static. update_cc_test_checks also isn't smart enough when the
attribute groups slightly differ.

Diff Detail

Event Timeline

arsenm created this revision.Jun 13 2023, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 9:43 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
arsenm requested review of this revision.Jun 13 2023, 9:43 AM
arsenm updated this revision to Diff 531048.Jun 13 2023, 1:30 PM

Use -verify

That seems like something we should fix. Visibility/dso really should be the same default. I don't know what that fp thing is

That seems like something we should fix. Visibility/dso really should be the same default. I don't know what that fp thing is

Whether you're allowed to turn x * y + z into an fma if you feel like it.

jdoerfert accepted this revision.Jun 29 2023, 7:05 PM
This revision is now accepted and ready to land.Jun 29 2023, 7:05 PM