Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h | ||
---|---|---|
88 | to generate (no s) | |
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
1171 | should we avoid reaching this altogether? I would hate for this to mess up with the semi-ring stuff.... | |
1174–1189 | I like the original v0/v1 a bit better, since lhs and rhs always reminds me of an assignment with lval and rval, and the vi corresponds to the ei in the children field | |
1184 | can this be an else-if or can both branches be taken?! | |
mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp | ||
334 | can we reach this "recursively" or is this always called from top? zeroMapSet(.) and use that asserting on kCmpI/F and asserting on non-kCmpI/F here? That would make a bit less special case iffing. |
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
---|---|---|
1156–1161 | remove empty line | |
1187 | why not have a third else { v0 = genExp v1 = genExp } | |
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_cmp.mlir | ||
26 | remove | |
90 | remove | |
93 | rephrase: that constructs test matrices and calls.... | |
123 | period at end |
to generate (no s)