This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Factor out power of 2 comparison patterns to helper; NFC
ClosedPublic

Authored by goldstein.w.n on Jun 12 2023, 10:23 AM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jun 12 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 10:23 AM
goldstein.w.n requested review of this revision.Jun 12 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 10:23 AM

I'm going to push this shortly.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2023, 11:53 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
fhahn added a subscriber: fhahn.Jun 15 2023, 8:33 AM

It looks like this patch may not be NFC and causing a mis-compile: https://github.com/llvm/llvm-project/issues/63327