This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] support dual sparse convolution.
ClosedPublic

Authored by Peiming on Jun 9 2023, 6:26 PM.

Diff Detail

Event Timeline

Peiming created this revision.Jun 9 2023, 6:26 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Jun 9 2023, 6:26 PM
Peiming planned changes to this revision.Jun 9 2023, 6:31 PM
Peiming planned changes to this revision.Jun 12 2023, 10:32 AM
Peiming added inline comments.Jun 15 2023, 11:16 AM
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
1518

How come that this does not causing any problem before?

Peiming updated this revision to Diff 531842.Jun 15 2023, 11:17 AM

revert unintended changes.

Peiming updated this revision to Diff 531844.Jun 15 2023, 11:21 AM

add code comments.

Peiming updated this revision to Diff 531848.Jun 15 2023, 11:25 AM

revert unintended change.

K-Wu accepted this revision.Jun 16 2023, 7:41 PM
This revision is now accepted and ready to land.Jun 16 2023, 7:41 PM
Peiming updated this revision to Diff 534000.Jun 23 2023, 10:00 AM

revert unintended changes.

K-Wu resigned from this revision.Jul 6 2023, 7:44 PM

Hey Peiming, I noticed that you didn't commit this yet. Is it abandoned or are you waiting for other reviewers?

This revision now requires review to proceed.Jul 6 2023, 7:44 PM

Hey Peiming, I noticed that you didn't commit this yet. Is it abandoned or are you waiting for other reviewers?

Oh, I forget about this, but let me also wait for Aart's review @aartbik

aartbik accepted this revision.Jul 7 2023, 5:16 PM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
58

I would say, non-continuous

59

tuple -> triple ;-)

1441

Finds, or Prune below

1442

Since we forward (no s) an iterator (a -> an)

1761

Wraps

an extra counting ...

2116–2119

triple

mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
1470

typo: multiple

1518

That is strange yes, do we have no tests for this at all?!

This revision is now accepted and ready to land.Jul 7 2023, 5:16 PM
Peiming updated this revision to Diff 538686.Jul 10 2023, 9:11 AM
Peiming marked 8 inline comments as done.

address comments.

Peiming updated this revision to Diff 538700.Jul 10 2023, 9:35 AM

fix asan.

This revision was landed with ongoing or failed builds.Jul 10 2023, 9:49 AM
This revision was automatically updated to reflect the committed changes.