This is an archive of the discontinued LLVM Phabricator instance.

[GlobalIsel][X86] Legalize G_SELECT
ClosedPublic

Authored by tschuett on Jun 8 2023, 7:37 AM.

Details

Diff Detail

Event Timeline

tschuett created this revision.Jun 8 2023, 7:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2023, 7:37 AM
tschuett published this revision for review.Jun 8 2023, 8:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2023, 8:34 AM
arsenm added inline comments.Jun 8 2023, 9:31 AM
llvm/lib/Target/X86/X86LegalizerInfo.cpp
313

select has two type indexes. I'm surprised this isn't asserting. You need to specify these as pairs with the condition type

tschuett updated this revision to Diff 529646.Jun 8 2023, 9:49 AM

use pairs in legalFor

inspired by AArch64

arsenm accepted this revision.Jun 8 2023, 9:51 AM
This revision is now accepted and ready to land.Jun 8 2023, 9:51 AM
This revision was landed with ongoing or failed builds.Jun 8 2023, 9:54 AM
This revision was automatically updated to reflect the committed changes.