The fully qualified name gets long in the TOC (especially on mobile).
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/tools/mlir-tblgen/OpDocGen.cpp | ||
---|---|---|
168–170 | Are there command line flags or options that can apply to op doc generation? I wonder if anyone would want to choose between these two behaviors. For example, the upstream dialects can have pretty short fully qualified names like ::mlir::math::FloorOp, while in projects like IREE we have longer names like ::mlir::iree_compiler::IREE::Stream::ExecutableOp. |
Flip to enabling specifying a prefix to strip, makes it so that projects could strip a common prefix rather than all or nothing. I think this is most useful for where folks are working in a given namespace. I could also make it an option to just use class name, but this does enable it still just manually.
SGTM. I think this will work well enough in IREE, since we have a tablegen_doc build system function (e.g. https://github.com/openxla/iree/blob/main/build_tools/cmake/iree_tablegen_doc.cmake) that we call for each dialect. We can add flags to each, or add a default that would apply across the project.
Are there command line flags or options that can apply to op doc generation? I wonder if anyone would want to choose between these two behaviors. For example, the upstream dialects can have pretty short fully qualified names like ::mlir::math::FloorOp, while in projects like IREE we have longer names like ::mlir::iree_compiler::IREE::Stream::ExecutableOp.