This is an archive of the discontinued LLVM Phabricator instance.

Differential D152361

[llvm-dlltool] Ignore the --temp-prefix option
ClosedPublic

Authored by mstorsjo on Jun 7 2023, 4:39 AM.

Details

Reviewers
alvinhochun
mati865
jeremyd2019
Commits
rG6540157fe389: [llvm-dlltool] Ignore the --temp-prefix option
Summary

llvm-dlltool tolerates unknown options as long as they are plain
flags, but if given the parameter value as a separate argument,
e.g. "--temp-prefix foo", it fails to ignore it.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 7 2023, 4:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 4:39 AM
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. · View Herald Transcript
mstorsjo requested review of this revision.Jun 7 2023, 4:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 4:39 AM
Harbormaster completed remote builds in B237234: Diff 529252.Jun 7 2023, 5:40 AM
mati865 accepted this revision.Jun 7 2023, 7:28 AM

LGTM

This revision is now accepted and ready to land.Jun 7 2023, 7:28 AM
jeremyd2019 added inline comments.Jun 7 2023, 9:06 AM
llvm/lib/ToolDrivers/llvm-dlltool/Options.td
29

copy/pasteo?

mstorsjo added inline comments.Jun 7 2023, 9:11 AM
llvm/lib/ToolDrivers/llvm-dlltool/Options.td
29

Oops, yes indeed. Thanks for catching it!

Closed by commit rG6540157fe389: [llvm-dlltool] Ignore the --temp-prefix option (authored by mstorsjo). · Explain WhyJun 8 2023, 1:23 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG6540157fe389: [llvm-dlltool] Ignore the --temp-prefix option.
jeremyd2019 mentioned this in D152363: [llvm-dlltool] Implement the --no-leading-underscore option.Jun 8 2023, 9:48 PM

Revision Contents

PathSize
llvm/
lib/
ToolDrivers/
llvm-dlltool/
3 lines
test/
tools/
llvm-dlltool/
8 lines

Diff 529706

llvm/lib/ToolDrivers/llvm-dlltool/Options.td

Show All 18 Lines
// The flags below do nothing. They are defined only for dlltool compatibility. // The flags below do nothing. They are defined only for dlltool compatibility.
//============================================================================== //==============================================================================
def S: JoinedOrSeparate<["-"], "S">, HelpText<"Assembler">; def S: JoinedOrSeparate<["-"], "S">, HelpText<"Assembler">;
def S_alias: JoinedOrSeparate<["--"], "as">, Alias<S>; def S_alias: JoinedOrSeparate<["--"], "as">, Alias<S>;
def f: JoinedOrSeparate<["-"], "f">, HelpText<"Assembler Flags">; def f: JoinedOrSeparate<["-"], "f">, HelpText<"Assembler Flags">;
def f_alias: JoinedOrSeparate<["--"], "as-flags">, Alias<f>; def f_alias: JoinedOrSeparate<["--"], "as-flags">, Alias<f>;
def t: JoinedOrSeparate<["-"], "t">, HelpText<"Prefix for temporary files (ignored)">;
def t_alias: JoinedOrSeparate<["--"], "temp-prefix">, Alias<t>;
jeremyd2019Unsubmitted
Not Done
ReplyInline Actions
def t: JoinedOrSeparate<["-"], "t">, HelpText<"Prefix for temporary files (ignored)">;
- def t_alias: JoinedOrSeparate<["--"], "temp-prefix">, Alias<f>;
+ def t_alias: JoinedOrSeparate<["--"], "temp-prefix">, Alias<t>;

copy/pasteo?

jeremyd2019: copy/pasteo?
mstorsjoAuthorUnsubmitted
Done
ReplyInline Actions

Oops, yes indeed. Thanks for catching it!

mstorsjo: Oops, yes indeed. Thanks for catching it!

llvm/test/tools/llvm-dlltool/ignored-opts.def

  • This file was added.
; RUN: llvm-dlltool -m i386 -d %s -l %t.a --temp-prefix foo
; RUN: llvm-dlltool -m i386 -d %s -l %t.a --temp-prefix=foo
; RUN: llvm-dlltool -m i386 -d %s -l %t.a -t foo
; RUN: llvm-dlltool -m i386 -d %s -l %t.a -tfoo
LIBRARY test.dll
EXPORTS
TestFunction