This is an archive of the discontinued LLVM Phabricator instance.

Differential D152165

[InstCombine] Precommit tests for contractable fmuladd
Needs ReviewPublic

Authored by foad on Jun 5 2023, 7:35 AM.

Details

Reviewers
nikic
spatel

Diff Detail

Event Timeline

foad created this revision.Jun 5 2023, 7:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 7:35 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
foad requested review of this revision.Jun 5 2023, 7:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 7:35 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
foad added a child revision: D152166: [InstCombine] Expand contractable fmuladd into fmul + fadd.Jun 5 2023, 7:44 AM
Harbormaster completed remote builds in B236633: Diff 528438.Jun 5 2023, 8:16 AM
foad updated this revision to Diff 535411.Jun 28 2023, 7:57 AM

Add an AMDGPU codegen test.

Herald added subscribers: kerbowa, jvesely. · View Herald TranscriptJun 28 2023, 7:57 AM
Harbormaster completed remote builds in B241801: Diff 535411.Jun 28 2023, 9:10 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
AMDGPU/
18 lines
Transforms/
InstCombine/
50 lines

Diff 535411

llvm/test/CodeGen/AMDGPU/fmuladd-to-fma.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
; RUN: opt < %s -passes=instcombine | llc -march=amdgcn -mcpu=gfx1030 | FileCheck %s
define float @f(float %arg) {
; CHECK-LABEL: f:
; CHECK: ; %bb.0: ; %bb
; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
; CHECK-NEXT: s_waitcnt_vscnt null, 0x0
; CHECK-NEXT: v_fma_f32 v0, v0, v0, 1.0
; CHECK-NEXT: v_add_f32_e32 v0, -1.0, v0
; CHECK-NEXT: s_setpc_b64 s[30:31]
bb:
%a = call contract float @llvm.fmuladd.f32(float %arg, float %arg, float 1.0)
%b = fadd reassoc nsz float %a, -1.0
ret float %b
}
declare float @llvm.fmuladd.f32(float, float, float)

llvm/test/Transforms/InstCombine/fma.ll

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%x.fneg = fneg float %x %x.fneg = fneg float %x
%y.fneg = fneg float %y %y.fneg = fneg float %y
%fmuladd = call float @llvm.fmuladd.f32(float %x.fneg, float %y.fneg, float %z) %fmuladd = call float @llvm.fmuladd.f32(float %x.fneg, float %y.fneg, float %z)
ret float %fmuladd ret float %fmuladd
} }
define float @fmuladd_fneg_x_fneg_y_contract(float %x, float %y, float %z) {
; CHECK-LABEL: @fmuladd_fneg_x_fneg_y_contract(
; CHECK-NEXT: [[FMULADD:%.*]] = call contract float @llvm.fmuladd.f32(float [[X:%.*]], float [[Y:%.*]], float [[Z:%.*]])
; CHECK-NEXT: ret float [[FMULADD]]
;
%x.fneg = fsub float -0.0, %x
%y.fneg = fsub float -0.0, %y
%fmuladd = call contract float @llvm.fmuladd.f32(float %x.fneg, float %y.fneg, float %z)
ret float %fmuladd
}
define float @fmuladd_fneg_x_fneg_y_fast(float %x, float %y, float %z) { define float @fmuladd_fneg_x_fneg_y_fast(float %x, float %y, float %z) {
; CHECK-LABEL: @fmuladd_fneg_x_fneg_y_fast( ; CHECK-LABEL: @fmuladd_fneg_x_fneg_y_fast(
; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[Y:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]] ; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]]
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%x.fneg = fsub float -0.0, %x %x.fneg = fsub float -0.0, %x
%y.fneg = fsub float -0.0, %y %y.fneg = fsub float -0.0, %y
%fmuladd = call fast float @llvm.fmuladd.f32(float %x.fneg, float %y.fneg, float %z) %fmuladd = call fast float @llvm.fmuladd.f32(float %x.fneg, float %y.fneg, float %z)
ret float %fmuladd ret float %fmuladd
} }
define float @fmuladd_unary_fneg_x_unary_fneg_y_contract(float %x, float %y, float %z) {
; CHECK-LABEL: @fmuladd_unary_fneg_x_unary_fneg_y_contract(
; CHECK-NEXT: [[FMULADD:%.*]] = call contract float @llvm.fmuladd.f32(float [[X:%.*]], float [[Y:%.*]], float [[Z:%.*]])
; CHECK-NEXT: ret float [[FMULADD]]
;
%x.fneg = fneg float %x
%y.fneg = fneg float %y
%fmuladd = call contract float @llvm.fmuladd.f32(float %x.fneg, float %y.fneg, float %z)
ret float %fmuladd
}
define float @fmuladd_unary_fneg_x_unary_fneg_y_fast(float %x, float %y, float %z) { define float @fmuladd_unary_fneg_x_unary_fneg_y_fast(float %x, float %y, float %z) {
; CHECK-LABEL: @fmuladd_unary_fneg_x_unary_fneg_y_fast( ; CHECK-LABEL: @fmuladd_unary_fneg_x_unary_fneg_y_fast(
; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[Y:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]] ; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]]
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%x.fneg = fneg float %x %x.fneg = fneg float %x
%y.fneg = fneg float %y %y.fneg = fneg float %y
▲ Show 20 Lines • Show All 63 Lines • ▼ Show 20 Lines
; CHECK-NEXT: [[FMULADD:%.*]] = call float @llvm.fmuladd.f32(float [[X:%.*]], float [[X]], float [[Z:%.*]]) ; CHECK-NEXT: [[FMULADD:%.*]] = call float @llvm.fmuladd.f32(float [[X:%.*]], float [[X]], float [[Z:%.*]])
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%x.fabs = call float @llvm.fabs.f32(float %x) %x.fabs = call float @llvm.fabs.f32(float %x)
%fmuladd = call float @llvm.fmuladd.f32(float %x.fabs, float %x.fabs, float %z) %fmuladd = call float @llvm.fmuladd.f32(float %x.fabs, float %x.fabs, float %z)
ret float %fmuladd ret float %fmuladd
} }
define float @fmuladd_fabs_x_fabs_x_contract(float %x, float %z) {
; CHECK-LABEL: @fmuladd_fabs_x_fabs_x_contract(
; CHECK-NEXT: [[FMULADD:%.*]] = call contract float @llvm.fmuladd.f32(float [[X:%.*]], float [[X]], float [[Z:%.*]])
; CHECK-NEXT: ret float [[FMULADD]]
;
%x.fabs = call float @llvm.fabs.f32(float %x)
%fmuladd = call contract float @llvm.fmuladd.f32(float %x.fabs, float %x.fabs, float %z)
ret float %fmuladd
}
define float @fmuladd_fabs_x_fabs_x_fast(float %x, float %z) { define float @fmuladd_fabs_x_fabs_x_fast(float %x, float %z) {
; CHECK-LABEL: @fmuladd_fabs_x_fabs_x_fast( ; CHECK-LABEL: @fmuladd_fabs_x_fabs_x_fast(
; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[X]] ; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[X]]
; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]] ; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]]
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%x.fabs = call float @llvm.fabs.f32(float %x) %x.fabs = call float @llvm.fabs.f32(float %x)
%fmuladd = call fast float @llvm.fmuladd.f32(float %x.fabs, float %x.fabs, float %z) %fmuladd = call fast float @llvm.fmuladd.f32(float %x.fabs, float %x.fabs, float %z)
Show All 13 Lines
; CHECK-LABEL: @fma_k_y_z_fast( ; CHECK-LABEL: @fma_k_y_z_fast(
; CHECK-NEXT: [[FMA:%.*]] = call fast float @llvm.fma.f32(float [[Y:%.*]], float 4.000000e+00, float [[Z:%.*]]) ; CHECK-NEXT: [[FMA:%.*]] = call fast float @llvm.fma.f32(float [[Y:%.*]], float 4.000000e+00, float [[Z:%.*]])
; CHECK-NEXT: ret float [[FMA]] ; CHECK-NEXT: ret float [[FMA]]
; ;
%fma = call fast float @llvm.fma.f32(float 4.0, float %y, float %z) %fma = call fast float @llvm.fma.f32(float 4.0, float %y, float %z)
ret float %fma ret float %fma
} }
define float @fmuladd_k_y_z_contract(float %y, float %z) {
; CHECK-LABEL: @fmuladd_k_y_z_contract(
; CHECK-NEXT: [[FMULADD:%.*]] = call contract float @llvm.fmuladd.f32(float [[Y:%.*]], float 4.000000e+00, float [[Z:%.*]])
; CHECK-NEXT: ret float [[FMULADD]]
;
%fmuladd = call contract float @llvm.fmuladd.f32(float 4.0, float %y, float %z)
ret float %fmuladd
}
define float @fmuladd_k_y_z_fast(float %y, float %z) { define float @fmuladd_k_y_z_fast(float %y, float %z) {
; CHECK-LABEL: @fmuladd_k_y_z_fast( ; CHECK-LABEL: @fmuladd_k_y_z_fast(
; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[Y:%.*]], 4.000000e+00 ; CHECK-NEXT: [[TMP1:%.*]] = fmul fast float [[Y:%.*]], 4.000000e+00
; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]] ; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[TMP1]], [[Z:%.*]]
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%fmuladd = call fast float @llvm.fmuladd.f32(float 4.0, float %y, float %z) %fmuladd = call fast float @llvm.fmuladd.f32(float 4.0, float %y, float %z)
ret float %fmuladd ret float %fmuladd
▲ Show 20 Lines • Show All 129 Lines • ▼ Show 20 Lines
; CHECK-LABEL: @fmuladd_x_y_m0( ; CHECK-LABEL: @fmuladd_x_y_m0(
; CHECK-NEXT: [[FMA:%.*]] = fmul float [[X:%.*]], [[Y:%.*]] ; CHECK-NEXT: [[FMA:%.*]] = fmul float [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: ret float [[FMA]] ; CHECK-NEXT: ret float [[FMA]]
; ;
%fma = call float @llvm.fmuladd.f32(float %x, float %y, float -0.0) %fma = call float @llvm.fmuladd.f32(float %x, float %y, float -0.0)
ret float %fma ret float %fma
} }
define float @fmuladd_x_1_z_contract(float %x, float %z) {
; CHECK-LABEL: @fmuladd_x_1_z_contract(
; CHECK-NEXT: [[FMULADD:%.*]] = fadd contract float [[X:%.*]], [[Z:%.*]]
; CHECK-NEXT: ret float [[FMULADD]]
;
%fmuladd = call contract float @llvm.fmuladd.f32(float %x, float 1.0, float %z)
ret float %fmuladd
}
define float @fmuladd_x_1_z_fast(float %x, float %z) { define float @fmuladd_x_1_z_fast(float %x, float %z) {
; CHECK-LABEL: @fmuladd_x_1_z_fast( ; CHECK-LABEL: @fmuladd_x_1_z_fast(
; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[X:%.*]], [[Z:%.*]] ; CHECK-NEXT: [[FMULADD:%.*]] = fadd fast float [[X:%.*]], [[Z:%.*]]
; CHECK-NEXT: ret float [[FMULADD]] ; CHECK-NEXT: ret float [[FMULADD]]
; ;
%fmuladd = call fast float @llvm.fmuladd.f32(float %x, float 1.0, float %z) %fmuladd = call fast float @llvm.fmuladd.f32(float %x, float 1.0, float %z)
ret float %fmuladd ret float %fmuladd
} }
▲ Show 20 Lines • Show All 376 Lines • Show Last 20 Lines