This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][NFC] Drop MMap events for deleted files
ClosedPublic

Authored by Amir on Jun 1 2023, 4:35 PM.

Details

Reviewers
rafauler
maksfb
Group Reviewers
Restricted Project
Commits
rGa478a0913121: [BOLT][NFC] Drop MMap events for deleted files
Summary

Don't parse/handle mmap events with "(deleted)" filename.

Diff Detail

Event Timeline

Amir created this revision.Jun 1 2023, 4:35 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Amir requested review of this revision.Jun 1 2023, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 4:35 PM
rafauler accepted this revision.Jun 5 2023, 12:47 PM

Where does this happen?

This revision is now accepted and ready to land.Jun 5 2023, 12:47 PM
Amir added a comment.Jun 5 2023, 1:00 PM

I observed that with perf data here: https://github.com/rafaelauler/bolt-tests/blob/main/test/X86/perf2bolt-multiple-edge.test#L13
Not sure how common is that, but "(deleted)" shows up in a couple of places in kernel, notably as DSO__DELETED in linux/tools/perf/util/map.c: https://github.com/search?q=repo%3Atorvalds%2Flinux%20%22(deleted)%22&type=code

This revision was automatically updated to reflect the committed changes.