This allows removing a bunch of boilerplate from the test suite and
reducing the amount of manual stuff contributors have to do when they
add a new public header.
Details
- Reviewers
Mordante - Group Reviewers
Restricted Project - Commits
- rG45307f1b0d27: [libc++] Refactor the mandatory header inclusion tests to .gen.py
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/utils/generate_header_inclusion_tests.py | ||
---|---|---|
98 | This way of enabling/disabling the tests is better than #ifdef. In this patch, the new tests are using #ifdef to be consistent with other .gen.py tests, but a future patch I have locally will transition everything to UNSUPPORTED markup instead. |
libcxx/include/typeinfo | ||
---|---|---|
11 ↗ | (On Diff #527163) | Please land this as a separate NFC commit. |
libcxx/test/libcxx/header_inclusions.gen.py | ||
13 | Not really related to this patch, but could a followup also validate __assert is included? | |
libcxx/utils/generate_header_inclusion_tests.py | ||
98 | Would it be possible to post these as stacked commits? That makes it easier to determine how happy I am with this patch. I feel we loose some nice features, but when I see how they will return I probably feel better about the temporary loss. |
Not really related to this patch, but could a followup also validate __assert is included?