This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Allow bit fields in SearchableTables.
ClosedPublic

Authored by rampitec on May 30 2023, 2:52 PM.

Diff Detail

Event Timeline

rampitec created this revision.May 30 2023, 2:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 2:52 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
rampitec requested review of this revision.May 30 2023, 2:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 2:52 PM

This patch is labeled as NFC but has new functionality.

llvm/utils/TableGen/SearchableTableEmitter.cpp
178

Indented too far.

rampitec updated this revision to Diff 526806.May 30 2023, 2:59 PM
rampitec marked an inline comment as done.
rampitec retitled this revision from [TableGen] Allow bit fileds in SearchableTables. NFC. to [TableGen] Allow bit fileds in SearchableTables..

This is NFC in terms that there is no in-tree backend code to use it yet. Removed NFC from the description anyway.

Fixed indent.

arsenm added a subscriber: arsenm.Jun 2 2023, 12:26 PM

Typo fileds in description

rampitec retitled this revision from [TableGen] Allow bit fileds in SearchableTables. to [TableGen] Allow bit fields in SearchableTables..Jun 2 2023, 12:29 PM
arsenm accepted this revision.Jun 2 2023, 1:48 PM
This revision is now accepted and ready to land.Jun 2 2023, 1:48 PM
This revision was automatically updated to reflect the committed changes.