This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add lowering for max operator
ClosedPublic

Authored by clementval on May 29 2023, 8:04 PM.

Details

Summary

Add support for the max operator in the reduction
clause.

Depdns on D151671

Diff Detail

Event Timeline

clementval created this revision.May 29 2023, 8:04 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 29 2023, 8:04 PM
clementval requested review of this revision.May 29 2023, 8:04 PM

Thank you. The comments I left for "min" apply here also:
https://reviews.llvm.org/D151671

Otherwise, great work!

jeanPerier added inline comments.Jun 13 2023, 5:40 AM
flang/lib/Lower/OpenACC.cpp
615

I advise using fir::genMax() (https://reviews.llvm.org/D151671).

jeanPerier accepted this revision.Jun 14 2023, 5:31 AM

Patch application issues, but the code looks good

This revision is now accepted and ready to land.Jun 14 2023, 5:31 AM

clang-format

This revision was automatically updated to reflect the committed changes.