This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] 4-align SGPR triples
ClosedPublic

Authored by foad on May 25 2023, 9:27 AM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Commits
rGe4284a7c70cd: [AMDGPU] 4-align SGPR triples
Summary

Previously SGPR triples like s[3:5] were aligned on a 3-SGPR boundary
which has no basis in hardware.

Aligning them on a 4-SGPR boundary is at least justified by the
architecture reference guide which says: "Quad-alignment of SGPRs is
required for operation on more than 64-bits".

Currently there are no instructions that take SGPR triples as operands
so the issue is latent.

Diff Detail

Event Timeline

foad created this revision.May 25 2023, 9:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 9:27 AM
foad requested review of this revision.May 25 2023, 9:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 9:27 AM
arsenm accepted this revision.May 25 2023, 10:06 AM

I guess we could index from odd bases

This revision is now accepted and ready to land.May 25 2023, 10:06 AM
This revision was automatically updated to reflect the committed changes.