Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D151338

[mlir][nvvm] Introduce `mbarrier.inval`
ClosedPublic
Actions

Authored by guraypp on May 24 2023, 7:22 AM.

Tags

Subscribers

View All 31 Subscribers

Details

Reviewers

ftynse
bondhugula
dcaballe
nicolasvasilache
qcolombet

Commits

rG4b38d17ff56a: [mlir][nvvm] Introduce `mbarrier.inval`

Summary

Introduce support for PTX's mbarrier.inval .

Contiunation of D151334

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

guraypp created this revision.May 24 2023, 7:22 AM

Herald added a reviewer: ftynse. · View Herald TranscriptMay 24 2023, 7:22 AM

Herald added a reviewer: bondhugula. · View Herald Transcript

Herald added a reviewer: dcaballe. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: bviyer, Moerafaat, zero9178 and 24 others. · View Herald Transcript

guraypp requested review of this revision.May 24 2023, 7:22 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 24 2023, 7:22 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache, jholewinski. · View Herald Transcript

Harbormaster completed remote builds in B234199: Diff 525171.May 24 2023, 7:23 AM

update

guraypp retitled this revision from [mlir][nvvm] Introduce `nvvm,barrier.inval` to [mlir][nvvm] Introduce `mbarrier.inval`.May 24 2023, 7:33 AM

Harbormaster completed remote builds in B234204: Diff 525179.May 24 2023, 7:33 AM

qcolombet added a subscriber: qcolombet.May 26 2023, 3:06 AM

qcolombet added inline comments.

mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td
201	Same comment as in https://reviews.llvm.org/D151334 on the pointer type.

rebase

Harbormaster completed remote builds in B239038: Diff 531624.Jun 15 2023, 12:20 AM

guraypp added a reviewer: qcolombet.Jun 15 2023, 9:06 AM

add i64 pointer

Harbormaster completed remote builds in B239307: Diff 531999.Jun 15 2023, 11:50 PM

qcolombet added inline comments.Jun 16 2023, 12:46 AM

mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td
201	You missed a spot :). This should be `LLVM_i64ptr`, right? With `LLVM_i64ptr` being: def LLVM_i64ptr : LLVM_IntPtrBase<64> I.e., no addrspace specifier. To match: def llvm_i64ptr_ty : LLVMPointerType<llvm_i64_ty>; // i64*

rebase

Harbormaster completed remote builds in B239333: Diff 532031.Jun 16 2023, 1:27 AM

qcolombet accepted this revision.Jun 16 2023, 4:33 AM

This revision is now accepted and ready to land.Jun 16 2023, 4:33 AM

rebase

This revision was landed with ongoing or failed builds.Jun 16 2023, 4:39 AM

Closed by commit rG4b38d17ff56a: [mlir][nvvm] Introduce `mbarrier.inval` (authored by guraypp). · Explain Why

This revision was automatically updated to reflect the committed changes.

guraypp added a commit: rG4b38d17ff56a: [mlir][nvvm] Introduce `mbarrier.inval`.

Harbormaster completed remote builds in B239373: Diff 532088.Jun 16 2023, 4:52 AM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

LLVMIR/

16 lines

test/

Dialect/

LLVMIR/

14 lines

Diff 532089

mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

Loading...

mlir/test/Dialect/LLVMIR/nvvm.mlir

Loading...