This is an archive of the discontinued LLVM Phabricator instance.

[mlir][nvvm] Introduce `mbarrier.inval`

Authored by guraypp on May 24 2023, 7:22 AM.



Introduce support for PTX's mbarrier.inval .

Contiunation of D151334

Diff Detail

Event Timeline

guraypp created this revision.May 24 2023, 7:22 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
guraypp requested review of this revision.May 24 2023, 7:22 AM
guraypp retitled this revision from [mlir][nvvm] Introduce `nvvm,barrier.inval` to [mlir][nvvm] Introduce `mbarrier.inval`.May 24 2023, 7:33 AM
qcolombet added inline comments.

Same comment as in on the pointer type.

guraypp updated this revision to Diff 531999.Jun 15 2023, 11:49 PM

add i64 pointer

qcolombet added inline comments.Jun 16 2023, 12:46 AM

You missed a spot :).

This should be LLVM_i64ptr, right?

With LLVM_i64ptr being:

def LLVM_i64ptr : LLVM_IntPtrBase<64>

I.e., no addrspace specifier.
To match:

def llvm_i64ptr_ty        : LLVMPointerType<llvm_i64_ty>;        // i64*
qcolombet accepted this revision.Jun 16 2023, 4:33 AM
This revision is now accepted and ready to land.Jun 16 2023, 4:33 AM
This revision was landed with ongoing or failed builds.Jun 16 2023, 4:39 AM
This revision was automatically updated to reflect the committed changes.